Last modified: 2013-11-25 06:20:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58743, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56743 - Grey "Automatically enable all new beta features" label looks disabled
Grey "Automatically enable all new beta features" label looks disabled
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
BetaFeatures (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Ryan Kaldari
https://www.mediawiki.org/wiki/Specia...
: design, easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-07 22:00 UTC by Bartosz Dziewoński
Modified: 2013-11-25 06:20 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2013-11-07 22:00:32 UTC
The grey "Automatically enable all new beta features" label looks disabled.
Comment 1 Luis Villa (WMF Legal) 2013-11-08 00:08:41 UTC
I had the exact same reaction, for what it is worth.
Comment 2 MZMcBride 2013-11-13 01:41:46 UTC
https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-betafeatures

Yeah, this text should be black, I think. Copying design.
Comment 3 Jared Zimmerman (WMF) 2013-11-13 14:59:50 UTC
Thanks for bringing this up, While in general we probably don't want to use pure black type, the original design for beta features had a white background, where as the actual implementation inherited the grey background from preferences, causing there to be a lot less contrast in the text. 

I think we could darken the text more, however I think it should be a bit different then the body text above.
Comment 4 Theopolisme 2013-11-23 03:52:38 UTC
Hmm, there's no need to over-design here -- pure black is consistent with everything else in [[Special:Preferences]].
Comment 5 Gerrit Notification Bot 2013-11-23 13:58:26 UTC
Change 97300 had a related patch set uploaded by Bartosz Dziewoński:
Removing CSS for auto-enroll option label

https://gerrit.wikimedia.org/r/97300
Comment 6 Ryan Kaldari 2013-11-23 15:40:50 UTC
Regardless of what color text we use for preferences in general, there's no need to make this one particular preference have a special font color (especially not grey which typically means disabled).
Comment 7 Gerrit Notification Bot 2013-11-23 16:09:31 UTC
Change 97300 merged by jenkins-bot:
Removing CSS for auto-enroll option label

https://gerrit.wikimedia.org/r/97300
Comment 8 Bartosz Dziewoński 2013-11-23 16:10:06 UTC
I'm just going to be bold and merge Kaldari's patch. The exact color can be decided on later, but the current grey is definitely not okay.
Comment 9 MZMcBride 2013-11-25 06:20:34 UTC
Thanks, Ryan and Bartosz!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links