Last modified: 2013-11-09 09:19:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58766, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56766 - When protecting a non-existent page, the API uses wrong preference to determine whether to watch page
When protecting a non-existent page, the API uses wrong preference to determi...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-08 11:12 UTC by This, that and the other (TTO)
Modified: 2013-11-09 09:19 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description This, that and the other (TTO) 2013-11-08 11:12:01 UTC 
When you use the API to protect a non-existent page with protections=create=sysop and watchlist=preferences, it seems to use the value of the "Add pages I create and files I upload to my watchlist" (wpWatchCreations) preference to decide  whether or not to add the page to your watchlist. 

Since no page is actually being created, this seems inappropriate.
Comment 1 This, that and the other (TTO) 2013-11-08 11:15:27 UTC 
This is easy to fix, but I'm just not sure what it should be changed to use... my gut feeling is to make watchlist=preferences behave like watchlist=no in this case. The other option would be to add a new pref (= sadness).
Comment 2 Brad Jorsch 2013-11-08 18:40:45 UTC 
The correct behavior would be to match that of the web UI, which uses 'watchdefault' ("watch pages I edit") for this situation.
Comment 3 Gerrit Notification Bot 2013-11-08 18:41:33 UTC 
Change 94399 had a related patch set uploaded by Anomie:
Cleanup watchlist preference usage

https://gerrit.wikimedia.org/r/94399
Comment 4 Gerrit Notification Bot 2013-11-08 22:27:05 UTC 
Change 94399 merged by jenkins-bot:
Cleanup watchlist preference usage

https://gerrit.wikimedia.org/r/94399
Comment 5 Umherirrender 2013-11-09 09:19:55 UTC 
Was successfully merged
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links