Last modified: 2013-12-11 17:40:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58821, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56821 - VisualEditor: Indent and list-related icons' direction should depend on content dir and not GUI dir
VisualEditor: Indent and list-related icons' direction should depend on conte...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-12-05
Assigned To: Moriel Schottlender
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-09 02:47 UTC by Moriel Schottlender
Modified: 2013-12-11 17:40 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Moriel Schottlender 2013-11-09 02:47:03 UTC 
Right now, CSSJanus flips toolbar icons by their definitions, so an icon indent-ltr would automatically turn to indent-rtl when user GUI is set to RTL.

However, the indent and list-related buttons don't depend on user GUI language but rather on the content language. If editing English content, the icon for "increase indent" should point from left to the right regardless of user GUI language, and the icon for "decrease indent" should point the other way.

For a quick demo, see:
https://www.mediawiki.org/wiki/User:Mooeypoo/IndentDemo?veaction=edit&setlang=he
(Wiki language is English/LTR and GUI is Hebrew/RTL)
Comment 1 Moriel Schottlender 2013-12-11 17:28:15 UTC 
This is fixed with this patch https://gerrit.wikimedia.org/r/#/c/95560/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links