Last modified: 2014-02-12 23:53:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58837, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56837 - MobileFrontend's "Mobile view" link in footer has duplicated &title= URL parameters and is not using a pretty URL
MobileFrontend's "Mobile view" link in footer has duplicated &title= URL para...
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-09 11:49 UTC by Liangent
Modified: 2014-02-12 23:53 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Bingle 2013-11-09 11:50:18 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1390
Comment 2 Bingle 2013-11-09 22:22:20 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1393
Comment 3 MZMcBride 2013-11-09 22:22:45 UTC
Thanks for filing this. I imagine this is a fairly recent regression.
Comment 4 Ryan Kaldari 2013-12-03 21:56:52 UTC
Writing a bug description since this bug doesn't have one...

If you click the 'Mobile view' link from any desktop article on one of the cluster wikis, you get sent to a URL that has the title param set twice. For example:
https://de.m.wikipedia.org/w/index.php?title=Honigdachs&title=Honigdachs

Interestingly, if you're coming from a redirect, the first title is the canonical title and the second is the redirect title:
https://m.mediawiki.org/w/index.php?title=ResourceLoader/Default_modules&title=Mediawiki.ui#mediawiki.ui

This doesn't happen on my local wiki, so it may be configuration related.
Comment 5 Arthur Richards 2013-12-04 23:07:00 UTC
Oof, definitely did not previously do this :( I'm able to replicate this on my local instance (Kaldari, I imagine you might not be able to replicate it because you do not have a separate mobile domain [wgMobileUrlTemplate] set up locally). I'll take a look.
Comment 6 Arthur Richards 2013-12-04 23:11:23 UTC
Found the culprit:
https://gerrit.wikimedia.org/r/#/c/90062/

I think this should be a quick fix.
Comment 7 Arthur Richards 2013-12-04 23:32:25 UTC
https://gerrit.wikimedia.org/r/#/c/99270/1
Comment 8 Arthur Richards 2013-12-04 23:33:52 UTC
Note that once this is deployed, it will take a while for the change to be reflected on *every* article in the WMF-hosted projects due to caching. Iirc, the TTL is 30 days, so it may take up to 30 days for the change to be ubiquitous.
Comment 9 Gerrit Notification Bot 2013-12-04 23:38:10 UTC
Change 99270 had a related patch set uploaded by MZMcBride:
Ensure title arg isn't set twice when creating 'mobile view' link

https://gerrit.wikimedia.org/r/99270
Comment 10 Gerrit Notification Bot 2013-12-05 17:59:16 UTC
Change 99270 merged by jenkins-bot:
Ensure title arg isn't set twice when creating 'mobile view' link

https://gerrit.wikimedia.org/r/99270

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links