Last modified: 2014-06-11 04:42:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58870, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56870 - Add DOM support for {{DISPLAYTITLE:xxx}}
Add DOM support for {{DISPLAYTITLE:xxx}}
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
DOM (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks: 56868
  Show dependency treegraph
 
Reported: 2013-11-10 16:47 UTC by James Forrester
Modified: 2014-06-11 04:42 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-11-10 16:47:55 UTC
Currently, …

{{DISPLAYTITLE:''F''o'''o'''}}

… round-trips to …

<span about="#mwt1" typeof="mw:Transclusion" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot; [[Main Page]]\n[[Category:&quot;,&quot;function&quot;:&quot;displaytitle&quot;},&quot;params&quot;:{},&quot;i&quot;:0}}]}" data-parsoid="{&quot;dsr&quot;:[7,37,null,null],&quot;pi&quot;:[[]]}"></span>

… which presumably is just fragments of another page's parse?
Comment 1 Alex Monk 2014-04-22 22:59:46 UTC
I began looking into what might be needed to do this earlier, based on how defaultsort is handled (which seems to have needed a similar transclusion -> meta item change).

Looking at parsoid/lib/ext.core.TemplateHandler.js, specifically the check on this.manager.env.conf.wiki.magicWords[property.trim()]). It'd be nice to be able to simply check that the result is 'displaytitle' (how the code works for defaultsort), but it seems that won't work without making 'DISPLAYTITLE:' an alias of 'DISPLAYTITLE' in MediaWiki core?

Anyway this is all obviously best left for a Parsoid developer so I stopped there.
Comment 2 Gerrit Notification Bot 2014-06-09 23:25:43 UTC
Change 138493 had a related patch set uploaded by Arlolra:
Add DOM support for {{DISPLAYTITLE}}

https://gerrit.wikimedia.org/r/138493
Comment 3 Gerrit Notification Bot 2014-06-11 00:06:31 UTC
Change 138493 merged by jenkins-bot:
Add DOM support for {{DISPLAYTITLE}}

https://gerrit.wikimedia.org/r/138493
Comment 4 Gerrit Notification Bot 2014-06-11 01:24:45 UTC
Change 138768 had a related patch set uploaded by Arlolra:
Rename page property to displaytitle

https://gerrit.wikimedia.org/r/138768
Comment 5 Gerrit Notification Bot 2014-06-11 04:11:28 UTC
Change 138768 merged by jenkins-bot:
Rename page property to displaytitle

https://gerrit.wikimedia.org/r/138768

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links