Last modified: 2014-01-29 21:17:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58877, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56877 - CirrusSearch should catch Elasticsearch query parse errors and try again with a more tolerant method
CirrusSearch should catch Elasticsearch query parse errors and try again with...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-11 01:28 UTC by Nik Everett
Modified: 2014-01-29 21:17 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nik Everett 2013-11-11 01:28:32 UTC
CirrusSearch does a lot to make sure that the query submitted by the user parses to a valid query_string search.  This mostly works but we keep finding funky queries that need escaping.  Right now when the query string doesn't parse we get a "temporary search error" that we through back to the user.  We should instead catch these errors, warn so we can find them and fix them, and then try using a more permissive query method.  We don't use that method by default because it doesn't support a bunch of the syntax that our users expect.  Not getting your syntax is better than getting an error.
Comment 1 Gerrit Notification Bot 2014-01-28 21:49:20 UTC
Change 110084 had a related patch set uploaded by Manybubbles:
Catch parse errors from Elasticsearch and retry

https://gerrit.wikimedia.org/r/110084
Comment 2 Gerrit Notification Bot 2014-01-29 21:17:40 UTC
Change 110084 merged by jenkins-bot:
Catch parse errors from Elasticsearch and retry

https://gerrit.wikimedia.org/r/110084

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links