Last modified: 2013-11-13 20:53:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58905, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56905 - MultimediaViewer shouldn't interfere with middle click
MultimediaViewer shouldn't interfere with middle click
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-11 13:46 UTC by [no longer active user]
Modified: 2013-11-13 20:53 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description [no longer active user] 2013-11-11 13:46:55 UTC
When I middle click or Ctrl+Click on an image, I don't expect MultiMediaViewer file viewer opened.
Comment 1 Bartosz Dziewoński 2013-11-11 14:00:59 UTC
I have fixed this issue in so many random places in the past that I have a snippet ready :P

// Do not interfere with non-left clicks or if modifier keys are pressed.
if ( e.which !== 1 || e.altKey || e.ctrlKey || e.shiftKey || e.metaKey ) {
    return;
}
Comment 2 Mark Holmquist 2013-11-12 17:28:05 UTC
Mind converting that into patch form? :D
Comment 3 Bartosz Dziewoński 2013-11-12 18:59:17 UTC
Will do as soon as you get me an extra day in the week. :P
Comment 4 Mark Holmquist 2013-11-12 19:00:18 UTC
I've filed a bug against Wikimedia/Site configuration to change the week structure on the cluster, please stand by.
Comment 5 Gerrit Notification Bot 2013-11-12 20:09:50 UTC
Change 94971 had a related patch set uploaded by Ebrahim:
Don't interfere with middle click

https://gerrit.wikimedia.org/r/94971
Comment 6 Gerrit Notification Bot 2013-11-13 20:52:42 UTC
Change 94971 merged by jenkins-bot:
Don't interfere with middle click

https://gerrit.wikimedia.org/r/94971
Comment 7 Mark Holmquist 2013-11-13 20:53:25 UTC
Thanks, Ebrahim!

Also MatmaRex, though I have to say, I'm disappointed with your lack of follow-through. :P

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links