Last modified: 2014-08-29 11:42:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58971, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 56971 - Close and Fullscreen button on MultimediaViewer should use embedded icon on CSS


Summary:	Close and Fullscreen button on MultimediaViewer should use embedded icon on CSS

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	MultimediaViewer (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-12 23:05 UTC by [no longer active user]
Modified:	2014-08-29 11:42 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description [no longer active user] 2013-11-12 23:05:55 UTC

This needed specially for users with lower internet speed to quickly close the overlay menu. It just need adding /* embed */ before https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/00e76b4a5d060cac535a9eba16a00f24d9940c5f/css/multilightbox.css#L50 and https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/00e76b4a5d060cac535a9eba16a00f24d9940c5f/css/ext.multimediaViewer.css#L70 (and a few other places) and ResouceLoader will take care of it.

Comment 1 Mark Holmquist 2013-11-12 23:08:19 UTC

The former file actually should be totally overridden by the latter.

Yay cascading! :)

Comment 2 Gerrit Notification Bot 2013-12-29 08:12:51 UTC

Change 104325 had a related patch set uploaded by Apsdehal:
Added Data URI embedding feature trigger

https://gerrit.wikimedia.org/r/104325

Comment 3 Tisza Gergő 2014-01-29 02:52:57 UTC

I don't see any non-embedded references at the moment, except in multilightbox.css which get overriden (and refer to non-existent files anyway).

Comment 4 Gerrit Notification Bot 2014-08-29 11:42:50 UTC

Change 104325 abandoned by Gilles:
Added Data URI embedding feature trigger

Reason:
I'm pretty sure all images in MV's CSS are embedded now.

https://gerrit.wikimedia.org/r/104325

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links