Last modified: 2014-02-12 23:52:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58973, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56973 - Refreshing page makes editor go strange
Refreshing page makes editor go strange
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Juliusz Gonera
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-12 23:28 UTC by Jon
Modified: 2014-02-12 23:52 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-11-12 23:28:00 UTC 
Click edit button to load the editor.
In editor.js add an alert to the callback for:

mw.loader.using( 'mobile.editor', function() {

THe router fires this alert twice. This seems to create 2 api requests... so not good.
Comment 1 Bingle 2013-11-12 23:30:19 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1397
Comment 2 Jon 2013-11-15 22:16:35 UTC 
Sorry this bug isn't clear.
When the hash is #editor/0 and you hit refresh the router fires twice. I'm not sure if this is problematic or not but seems strange. If I then edit and click the back button I get 2 confirmation messages to leave the editor overlay
Comment 3 Juliusz Gonera 2013-11-18 07:12:29 UTC 
I tracked this down. Working on a fix.
Comment 4 Gerrit Notification Bot 2013-11-18 08:12:04 UTC 
Change 95988 had a related patch set uploaded by JGonera:
Don't run Router#checkRoutes externally

https://gerrit.wikimedia.org/r/95988
Comment 5 Gerrit Notification Bot 2013-11-18 18:32:51 UTC 
Change 95988 merged by jenkins-bot:
Don't run Router#checkRoutes externally

https://gerrit.wikimedia.org/r/95988
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links