Last modified: 2014-01-21 02:05:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58976, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56976 - VisualEditor: Pawn ("♙") appears when clicking into the blank space above a new link inspector and inserting content
VisualEditor: Pawn ("♙") appears when clicking into the blank space above a n...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-12-05
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-13 00:06 UTC by Krinkle
Modified: 2014-01-21 02:05 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-11-13 00:06:21 UTC
Steps:
* Edit page
* Add heading "External links"
* Press Enter, click "Bulleted list" in toolbar
* Click on the link tool and paste a url in the link input widget
* Type a label where the cursor is

Expected:

 <h2>External links
 <ul><li> <a>Typing</a>

Actual:

 <h2>External links
 <ul><li> <a>http://example.org/foobarTyping</a>♙
Comment 1 Roan Kattouw 2013-11-13 00:11:10 UTC
Is there a JS error or exception in the console?
Comment 2 Krinkle 2013-11-13 00:15:47 UTC
(In reply to comment #1)
> Is there a JS error or exception in the console?

There is not.

Reduced steps:


Steps:
* Edit page with a list (or create a new unordered list)
* Create a new list item
* Click on the link tool and enter a url (e.g. "http://example.org") in the link input widget
* Type a label (e.g. "example") where the cursor is

Expected:
<a href="http://example.org">example</a>

Actual:
<a href="http://example.org">http://example.orgxample</a>♙


Note how the first character typed was ignored.
Comment 3 Roan Kattouw 2013-11-26 13:37:36 UTC
Clarification:

* Create an empty list item
* Open the link inspector
* Type a link target
* CLICK to position the cursor at the SAME PLACE where it was before
* The inspector DOES NOT close
* Type
* The first key press is ignored and inserts a pawn instead, the remaining key presses insert characters before the pawn

Root cause: when the document is focused, the inspector should close. We currently close the inspector when the selection changes, and usually clicking out of the inspector does change the selection, but in creation mode this isn't necessarily true.
Comment 4 Gerrit Notification Bot 2013-11-28 18:10:32 UTC
Change 98116 had a related patch set uploaded by Catrope:
Close inspectors when surface is focused but selection doesn't change

https://gerrit.wikimedia.org/r/98116
Comment 5 Gerrit Notification Bot 2013-12-03 21:39:25 UTC
Change 98116 merged by jenkins-bot:
Close inspectors when surface is focused but selection doesn't change

https://gerrit.wikimedia.org/r/98116

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links