Last modified: 2013-12-13 22:30:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58983, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 56983 - Implement serialisation of <meta property="mw:PageProp/notoc" /> and <meta property="mw:PageProp/forcetoc" />


Summary:	Implement serialisation of <meta property="mw:PageProp/notoc" /> and <meta pr...

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	serializer (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	---
Assigned To:	ssastry

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-13 03:31 UTC by James Forrester
Modified:	2013-12-13 22:30 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-11-13 03:31:03 UTC

These are currently implements in WT->HTML but not the other way around. Blocking further work on TOC status in VE - Gerrit change #95103.

Comment 1 ssastry 2013-11-14 23:54:38 UTC

This seems a bug in serializing new meta tags without data-parsoid. See below. Taking this and fixing.

--------

[subbu@earth lib] echo "__NOTOC__" | node parse --fetchConfig false --wt2wt
__NOTOC__
[subbu@earth lib] echo "<meta property='mw:PageProp/notoc' data-parsoid='{&quot;src&quot;:&quot;__NOTOC__&quot;,&quot;magicSrc&quot;:&quot;__NOTOC__&quot;}'/>" | node parse --html2wt
__NOTOC__
[subbu@earth lib] echo "<meta property='mw:PageProp/notoc' />" | node parse --html2wt
notoc

Comment 2 Gerrit Notification Bot 2013-11-15 00:41:36 UTC

Change 95574 had a related patch set uploaded by Subramanya Sastry:
(Bug 56983) Correctly serialize magic words added on client

https://gerrit.wikimedia.org/r/95574

Comment 3 Gerrit Notification Bot 2013-11-19 22:19:25 UTC

Change 95574 merged by jenkins-bot:
(Bug 56983) Correctly serialize magic words added on client

https://gerrit.wikimedia.org/r/95574

Comment 4 James Forrester 2013-11-20 05:22:25 UTC

(In reply to comment #3)
> Change 95574 merged by jenkins-bot:
> (Bug 56983) Correctly serialize magic words added on client
> 
> https://gerrit.wikimedia.org/r/95574

Does this mean this bug can be marked as FIXED?

Comment 5 ssastry 2013-11-20 19:37:58 UTC

Yes, and marking as such.

Comment 6 Gerrit Notification Bot 2013-12-13 19:53:35 UTC

Change 101262 had a related patch set uploaded by GWicke:
Merge "(Bug 56983) Correctly serialize magic words added on client"

https://gerrit.wikimedia.org/r/101262

Comment 7 Gerrit Notification Bot 2013-12-13 19:54:41 UTC

Change 101298 had a related patch set uploaded by GWicke:
(Bug 56983) Correctly serialize magic words added on client

https://gerrit.wikimedia.org/r/101298

Comment 8 Gerrit Notification Bot 2013-12-13 19:57:39 UTC

Change 101262 merged by GWicke:
Merge "(Bug 56983) Correctly serialize magic words added on client"

https://gerrit.wikimedia.org/r/101262

Comment 9 Gerrit Notification Bot 2013-12-13 19:57:46 UTC

Change 101298 merged by GWicke:
(Bug 56983) Correctly serialize magic words added on client

https://gerrit.wikimedia.org/r/101298

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links