Last modified: 2013-11-22 20:40:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58986, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56986 - Flow: Topic not fully collapsed if certain elements, such as unclosed templates, are in one of the posts
Flow: Topic not fully collapsed if certain elements, such as unclosed templat...
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-13 07:02 UTC by Quiddity
Modified: 2013-11-22 20:40 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Quiddity 2013-11-13 07:02:00 UTC 
Connected to 56981 and possibly other situations

In this topic http://ee-flow.wmflabs.org/w/index.php?title=User_talk:Quiddity&workflow=0506915cf3d0b62ef835fa163e68c4ac&action=view
the unclosed <small> element in the post by PiRSquared17 is preventing any of the posts after it from being collapsed.
Comment 1 spage 2013-11-13 07:33:52 UTC 
Yes, if there's unbalanced tag like small then additional following posts are nested inside <small> (leading to bug 56981), and the topic collapse only makes immediate child '.flow-post-container's of the topic invisible.

The short-term fix could be $hideElement = $topicContainer.find( '.flow-post-container' ) so even messed up HTML is hidden, but ideally each Flow post should be balanced HTML. (Forum software, RSS readers, and blog aggregators have been struggling with this for decades.)
Comment 2 spage 2013-11-13 07:42:39 UTC 
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/456, but people from the community are welcome to contribute here and in Gerrit.
Comment 3 spage 2013-11-22 20:40:41 UTC 
WONTFIX because this "shouldn't happen", and the specific bug causing the problem is fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links