Last modified: 2013-12-05 21:39:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59055, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57055 - Flow: Save moderation notes in revisions table
Flow: Save moderation notes in revisions table
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 57056
  Show dependency treegraph
 
Reported: 2013-11-14 15:37 UTC by Matthias Mullie
Modified: 2013-12-05 21:39 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthias Mullie 2013-11-14 15:37:05 UTC
IIRC, moderation notes should be saved in (a probably new column in) the revision table.
Comment 1 Oliver Keyes 2013-11-14 16:28:28 UTC
Define "moderation"? Standard for the moment is for rollback to be stored in rev_comment - an existing field - while revisiondelete and suppress are stored in logging. I'd actually advocate moving "hide" into the logging, rather than the revision table, unless there are factors I'm unaware of.
Comment 2 Matthias Mullie 2013-11-14 16:40:41 UTC
moderation = hide/delete/suppress/restore

We already add an entry to logging, when a post is suppressed/deleted (not sure why hiding should not log either, or what log it should be in; perhaps file another bug if you believe it should write to log too?)

This is more of a code thing. We currently "only" save the moderation reason to the log (which, for hiding, currently equals not at all). We'll need to have that information available (we'll probably need to display it in some places, why ask it otherwise) in the Flow revisions table as well.

The only way to get the moderation reason right now would be to query the logging table. Not only can't that be done in an effective way on a per-revision basis, it'd get even more troublesome if/once Flow is on its separate database.
Comment 3 Matthias Mullie 2013-11-14 16:41:18 UTC
Oh also see follow-up bug https://bugzilla.wikimedia.org/show_bug.cgi?id=57056, something we can't accomplish until we also save the moderation reason in Flow's tables.
Comment 4 Oliver Keyes 2013-11-14 16:45:24 UTC
Makes sense!
Comment 5 spage 2013-11-14 18:29:59 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/461, but people from the community are welcome to contribute here and in Gerrit.
Comment 6 Gerrit Notification Bot 2013-11-18 05:20:57 UTC
Change 95985 had a related patch set uploaded by Werdna:
[SCHEMA CHANGE] Refactor of moderation logging.

https://gerrit.wikimedia.org/r/95985
Comment 7 Gerrit Notification Bot 2013-11-26 12:10:42 UTC
Change 95985 merged by jenkins-bot:
[SCHEMA CHANGE] Refactor of moderation logging.

https://gerrit.wikimedia.org/r/95985

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links