Last modified: 2014-01-06 11:17:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59064, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57064 - migrate mediawiki/tools/codesniffer to deployment system
migrate mediawiki/tools/codesniffer to deployment system
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-14 17:16 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-01-06 11:17 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2013-11-14 17:16:59 UTC
mediawiki/tools/codesniffer hold the MediaWiki style standard for PHP CodeSniffer. It is currently deployed as a submodule of integration/jenkins.git which is not ideal and error prone.  Instead we should deploy it using the Wikimedia deployment system:

* in puppet add entry for mediawiki/tools/codesniffer to integration/codesniffer

* update jenkins jobs / slave scripts to point to the new path (something like /srv/deployment/integration/codesniffer/...)
Comment 1 Gerrit Notification Bot 2013-11-14 17:25:00 UTC
Change 95446 had a related patch set uploaded by Hashar:
deployment: mediawiki/tools/codesniffer for Jenkins CI slaves

https://gerrit.wikimedia.org/r/95446
Comment 2 Gerrit Notification Bot 2013-11-14 17:26:19 UTC
Change 95446 merged by Ori.livneh:
deployment: mediawiki/tools/codesniffer for Jenkins CI slaves

https://gerrit.wikimedia.org/r/95446
Comment 3 Antoine "hashar" Musso (WMF) 2013-11-14 20:45:46 UTC
The standard is now deployable with git-deploy /srv/deployment/integration/mediawiki-tools-codesniffe . I did the initial sync to the Jenkins slaves.

Still have to update the scripts / macros.
Comment 4 Gerrit Notification Bot 2013-11-14 20:49:56 UTC
Change 95531 had a related patch set uploaded by Hashar:
run-phpcs-mw: point to standard deployed via git-deploy

https://gerrit.wikimedia.org/r/95531
Comment 5 Gerrit Notification Bot 2013-11-14 20:59:49 UTC
Change 95531 merged by jenkins-bot:
run-phpcs-mw: point to standard deployed via git-deploy

https://gerrit.wikimedia.org/r/95531
Comment 6 Antoine "hashar" Musso (WMF) 2014-01-06 11:17:58 UTC
uninstalled phpcs from gallium:

root@gallium:~# pear uninstall PHP_CodeSniffer
uninstall ok: channel://pear.php.net/PHP_CodeSniffer-1.4.7

All jobs are using the phpcs shell wrapper.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links