Last modified: 2014-03-17 20:27:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59088, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57088 - make-release doesn't include the correct extension branch
make-release doesn't include the correct extension branch
Status: NEW
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-15 00:33 UTC by Chris Steipp
Modified: 2014-03-17 20:27 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris Steipp 2013-11-15 00:33:51 UTC
I've been working around this by manually checking out the correct branch in my local versions of the extension repos, but it bit me today.

Can we have the script do this automatically?
Comment 1 Antoine "hashar" Musso (WMF) 2013-11-15 14:40:26 UTC
Extensions branches being REL1_20 REL1_21 .. Aka based on MediaWiki major version I believe.  Should be possible by iterating over each of the git sub directories.
Comment 2 Antoine "hashar" Musso (WMF) 2013-11-16 22:01:21 UTC
Looking at it again, that is a serious issue :/

I use --git-root to point the script to my local repositories. make-release ends up using their current HEAD which might be severely outdated.

https://gerrit.wikimedia.org/r/#/c/95825/ at least update the local repositories.  Would have to clone them using --mirror to keep the remote branches in.


As for the branch, the version decomposer abuse the term 'branch' when it is really a tag or major version. I would clean that up and make sure 'branch' point to some 'REL_**' or 'master'.   That is not trivial though.


Once we know which REL_ is being processed we can clone the extension using it.
Comment 3 Gerrit Notification Bot 2013-11-18 11:58:22 UTC
Change 96016 had a related patch set uploaded by Hashar:
make-release: unit tests for MwVersion

https://gerrit.wikimedia.org/r/96016
Comment 4 Gerrit Notification Bot 2013-11-18 16:30:00 UTC
Change 96038 had a related patch set uploaded by Hashar:
make-release: enhance MwVersion

https://gerrit.wikimedia.org/r/96038
Comment 5 Antoine "hashar" Musso (WMF) 2013-11-18 18:22:28 UTC
The changes above clean up MwVersion which we can later improve to forge REL#_##|master branches.
Comment 6 Gerrit Notification Bot 2013-12-02 11:09:24 UTC
Change 96016 merged by jenkins-bot:
make-release: unit tests for MwVersion

https://gerrit.wikimedia.org/r/96016
Comment 7 Gerrit Notification Bot 2013-12-02 11:11:07 UTC
Change 96038 merged by jenkins-bot:
make-release: enhance MwVersion

https://gerrit.wikimedia.org/r/96038
Comment 8 Andre Klapper 2014-02-14 12:59:07 UTC
[Resetting status as there are no patches left here to merge.]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links