Last modified: 2013-11-18 22:55:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59090, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57090 - GuidedTourHooks::onResourceLoaderRegisterModules failed to return true
GuidedTourHooks::onResourceLoaderRegisterModules failed to return true
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-15 01:04 UTC by Matthew Flaschen
Modified: 2013-11-18 22:55 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2013-11-15 01:04:31 UTC 
This looks like a straightforward missing 'return true', but that doesn't explain why it wasn't detected earlier.
Comment 2 Matthew Flaschen 2013-11-18 22:44:22 UTC 
The reason I didn't notice this is because it's not required since https://gerrit.wikimedia.org/r/#/c/70328/ .  

Now that I understand the issue, I'll still do this for backwards compatibility.
Comment 3 Gerrit Notification Bot 2013-11-18 22:49:41 UTC 
Change 96164 had a related patch set uploaded by Mattflaschen:
Add return true to hook for back-compat with older core.

https://gerrit.wikimedia.org/r/96164
Comment 4 Gerrit Notification Bot 2013-11-18 22:51:29 UTC 
Change 96164 merged by jenkins-bot:
Add return true to hook for back-compat with older core.

https://gerrit.wikimedia.org/r/96164
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links