Last modified: 2014-02-03 08:39:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59098, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57098 - SpecialPasswordReset when called does not obey an optional returnto parameter
SpecialPasswordReset when called does not obey an optional returnto parameter
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-15 10:19 UTC by T. Gries
Modified: 2014-02-03 08:39 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
federicoleva: Backport_to_Stable-


Attachments

Description T. Gries 2013-11-15 10:19:03 UTC
Observed, that the returnto= parameter is ignored. 

https://en.wikipedia.org/w/index.php?title=Special:PasswordReset&returnto=Special:UserLogin

is ignored.


SpecialPasswordReset.php lines 301-316

Perhaps this comes from the missing parameter passing, and simply and always returning to the Main page in
https://git.wikimedia.org/blob/mediawiki%2Fcore.git/146ea32031dba266831d0f7820f2bc8214f34a58/includes%2Fspecials%2FSpecialPasswordReset.php#L316

	public function onSuccess() {

...
		$this->getOutput()->addWikiMsg( 'passwordreset-emailsent' );
		$this->getOutput()->returnToMain();
	}



I need the PasswordReset with a working returnto for several bugfixes for E:OpenID.
Comment 1 Alexandre Emsenhuber [IAlex] 2013-11-20 08:05:59 UTC
Fixed in https://gerrit.wikimedia.org/r/96253
Comment 2 T. Gries 2013-11-22 06:55:41 UTC
I suggest to backport this fix and then to check whether it solves the https://bugzilla.wikimedia.org/show_bug.cgi?id=57289 .

Unsure, whether I have to reopen this bug. I reopen it provisionally.
Comment 3 Greg Grossmeier 2013-11-22 16:14:39 UTC
(In reply to comment #2)
> I suggest to backport this fix and then to check whether it solves the
> https://bugzilla.wikimedia.org/show_bug.cgi?id=57289 .

You can check whether this fixes that issue on any of the wikis that have 1.23wmf5, which, as of Fri Nov 22nd is:
test.wikipedia.org
test2.wikipedia.org
mediawiki.org
test.wikidata.org

And always, you can test whatever is in master (merged), after about 5 minutes after it's merged, on the Beta Cluster:
eg: en.wikipedia.beta.wmflabs.org

Let me know what you find out.
Comment 4 T. Gries 2013-11-22 19:02:20 UTC
In www.mediawiki,org : Not solved


After changing the password, see http://i.imgur.com/7ADHPHH.png

URL:

https://www.mediawiki.org/w/index.php?title=Special:ChangePassword&returnto=&returntoquery=&fromhttp=1

Problem is not solved, in my view.
Comment 5 Alexandre Emsenhuber [IAlex] 2013-11-22 19:49:04 UTC
Working correctly on mediawiki.org; closing the bug again.
Comment 6 T. Gries 2013-11-22 19:50:40 UTC
(In reply to comment #5)
> Working correctly on mediawiki.org; closing the bug again.

Do you mean it is correct to see http://i.imgur.com/7ADHPHH.png after correctly having changed the temporary to the new password ?
Comment 7 T. Gries 2013-11-22 19:51:52 UTC
It would be better to guide the user and to show then a page saying "You have successfully changed your password. Please log in with the new password."

and to present a link to SpecialUserLogin there.
Comment 8 Alexandre Emsenhuber [IAlex] 2013-11-22 19:54:03 UTC
(In reply to comment #6)
> Do you mean it is correct to see http://i.imgur.com/7ADHPHH.png after
> correctly
> having changed the temporary to the new password ?
(In reply to comment #7)
> It would be better to guide the user and to show then a page saying "You have
> successfully changed your password. Please log in with the new password."
> 
> and to present a link to SpecialUserLogin there.
This bug is about Special:PasswordReset; not Special:ChangeEmail.
Comment 9 T. Gries 2013-11-22 19:55:41 UTC
(In reply to comment #8)
> (In reply to comment #6)
> > Do you mean it is correct to see http://i.imgur.com/7ADHPHH.png after
> > correctly
> > having changed the temporary to the new password ?
> (In reply to comment #7)
> > It would be better to guide the user and to show then a page saying "You have
> > successfully changed your password. Please log in with the new password."
> > 
> > and to present a link to SpecialUserLogin there.
> This bug is about Special:PasswordReset; not Special:ChangeEmail.

Yes. It is! This is Special:PasswordReset!
Comment 10 T. Gries 2013-11-22 19:56:32 UTC
This is why I am saying, respectfully stated, you are wrong, that this is solved, in my view, it is not solved.
Comment 11 Nemo 2014-02-03 08:39:26 UTC
No commits to backport, reopen if there should be any.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links