Last modified: 2014-08-09 12:54:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59101, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57101 - browser tests must normalize font-family
browser tests must normalize font-family
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Kartik Mistry
: browser-test-bug
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-15 12:40 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-08-09 12:54 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2013-11-15 12:40:39 UTC
The .autonym class from resources/css/ext.uls.webfonts.css is:

 font-family: 'Autonym', sans-serif;

With single quotes and a space after the comma.


Firefox simply strip the whitespace and the following test works:

 on(PanelPage).autonym_element.style("font-family").should == "'Autonym',sans-serif"


On the other hand, phantomjs:
* strip the single quotes
* keep the white space

Hence it yield:

 Autonym, sans-serif


That makes the tests fails under phantomjs.


The style("font-family").should test should normalize the list of fonts or be replaced by something that yield a list of fonts we can compare against. Or maybe just assert it contains the Autonym string.
Comment 1 Gerrit Notification Bot 2014-02-06 15:39:58 UTC
Change 111804 had a related patch set uploaded by KartikMistry:
Normalize the font-family name in browser test

https://gerrit.wikimedia.org/r/111804
Comment 2 Gerrit Notification Bot 2014-02-07 16:18:23 UTC
Change 111804 merged by Cmcmahon:
Normalize the font-family name in browser test

https://gerrit.wikimedia.org/r/111804
Comment 3 Niklas Laxström 2014-02-07 19:18:14 UTC
Assuming the patch is generic enough.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links