Last modified: 2014-03-12 21:39:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59104, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 57104 - VisualEditor: Browser tests assume the User namespace is VE-editable


Summary:	VisualEditor: Browser tests assume the User namespace is VE-editable

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2014-03-13
Assigned To:	James Forrester

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-15 13:39 UTC by Antoine "hashar" Musso (WMF)
Modified:	2014-03-12 21:39 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2013-11-15 13:39:39 UTC

The browser tests are acting on User:Selenium_user. On a default VisualEditor installation, the User namespace does not have VisualEditor enabled.

The easiest would be to enable VisualEditor on user page I guess.

Comment 1 Antoine "hashar" Musso (WMF) 2013-12-05 14:15:13 UTC

Jeff, Željko that might be appealing to you :-]

Comment 2 Željko Filipin 2013-12-05 15:09:57 UTC

And Chris. :)

Comment 3 Željko Filipin 2013-12-05 15:10:37 UTC

I have just noticed that it is already assigned to Chris (_after_ adding him to cc).

Comment 4 Jeff Hall 2013-12-05 17:08:30 UTC

This issue was resolved with the following commit:

https://gerrit.wikimedia.org/r/#/c/99257/

Comment 5 Jeff Hall 2013-12-05 17:11:41 UTC

Ignore previous comment - I meant to put that comment in BZ 57103.

Comment 6 James Forrester 2014-03-01 02:22:06 UTC

Is this still true?

Comment 7 Antoine "hashar" Musso (WMF) 2014-03-04 09:42:21 UTC

Yup the VisualEditor.php entry point has:

 $wgVisualEditorNamespaces = $wgContentNamespaces;

Which does not include the User namespace.  So the tests should probably only hit the content namespaces.

Comment 8 Gerrit Notification Bot 2014-03-11 00:14:05 UTC

Change 118029 had a related patch set uploaded by Jforrester:
Enable VisualEditor by default in NS_USER as well as $wgContentNamespaces

https://gerrit.wikimedia.org/r/118029

Comment 9 Gerrit Notification Bot 2014-03-12 21:39:34 UTC

Change 118029 merged by jenkins-bot:
Enable VisualEditor by default in NS_USER as well as $wgContentNamespaces

https://gerrit.wikimedia.org/r/118029

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links