Last modified: 2013-11-19 19:24:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59111, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57111 - clean up obsolete VE API dependency
clean up obsolete VE API dependency
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-15 19:54 UTC by spage
Modified: 2013-11-19 19:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-11-15 19:54:59 UTC
AIUI, Flow no longer uses VE's API to convert from/to wikitext/html, it posts API requests to Parsoid's URL if its available.

I think this means:
* Hooks.php onSetupAfterCache() is obsolete, (and has been since we occupied namespaces?!),
* Flow should have its own parameters $wgFlowParsoidURL, $wgFlowParsoidPrefix, $wgFlowParsoidTimeout which in comments can default to the $wgVisualEditor* values.
* Clean up obsolete comments in ParsoidUtils.php

This will make it clearer that Flow can work with Parsoid even if the VisualEditor extension isn't installed.

(Is the Parsoid extension even required on MediaWiki servers in a cluster arrangement where only one machine runs the Parsoid nodejs service?)  I guess yes in order to "trigger Parsoid cache updates".)
Comment 1 Matthias Mullie 2013-11-16 09:10:24 UTC
Coincidentally, I had been working on that yesterday: https://gerrit.wikimedia.org/r/#/c/95605/

onSetupAfterCache still needs to be removed in there, though.
Comment 2 spage 2013-11-18 08:03:31 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/470, but people from the community are welcome to contribute here and in Gerrit.
Comment 3 Gerrit Notification Bot 2013-11-19 15:32:28 UTC
Change 95605 had a related patch set uploaded by Matthias Mullie:
(bug 57111)  clean up obsolete VE API dependency

https://gerrit.wikimedia.org/r/95605
Comment 4 Gerrit Notification Bot 2013-11-19 19:21:22 UTC
Change 95605 merged by jenkins-bot:
(bug 57111)  clean up obsolete VE API dependency

https://gerrit.wikimedia.org/r/95605

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links