Last modified: 2013-12-03 20:50:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59115, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57115 - Installer should set $wgNoFollowLinks to false in LocalSettings.php if "Authorized editors only" user rights profile is selected
Installer should set $wgNoFollowLinks to false in LocalSettings.php if "Autho...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
unspecified
All All
: Normal minor (vote)
: 1.23.0 release
Assigned To: Nathan Larson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-15 22:19 UTC by Nathan Larson
Modified: 2013-12-03 20:50 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nathan Larson 2013-11-15 22:19:29 UTC
The installer should set $wgNoFollowLinks to false in LocalSettings.php if the "Authorized editors only" or "Private wiki" user rights profile is selected. These wikis cannot be attacked by spambots because editing is only by registered users and registration is by invitation only. Therefore, there is no need to use nofollow to deter spam.

Nofollow would in fact likely be counterproductive to the wiki owner's purposes, since it would hinder him from raising the pagerank of sites he and his small circle of approved editors link to, and which he therefore presumably wants to attract traffic to. We should act under the assumption that he would prefer to have nofollow switched off.
Comment 1 Nathan Larson 2013-11-16 00:04:42 UTC
Actually, scratch that part about the "private wiki" -- those wouldn't be accessible to the general public even to read.
Comment 2 Nemo 2013-11-16 00:16:05 UTC
Makes sense, though it would need a comment inviting the sysadmin to revisit the config if they later change access (can the installer control in what order configs are?). Just in case someone chooses the profile temporarily and then changes LocalSettings.php.
Comment 3 Nathan Larson 2013-11-16 02:08:06 UTC
Okay, so it will need to be explained in a clear and succinct way in a LocalSettings.php comment. How about: "Set $wgNoFollowLinks to true if you open up your wiki to editing by the general public and wish to apply nofollow to external links as a deterrent to spammers."
Comment 4 Gerrit Notification Bot 2013-11-16 04:54:20 UTC
Change 95755 had a related patch set uploaded by leucosticte:
Set $wgNoFollowLinks to false if "Authorized editors only" selected

https://gerrit.wikimedia.org/r/95755
Comment 5 Nathan Larson 2013-11-16 07:12:57 UTC
(In reply to comment #2)
> Makes sense, though it would need a comment inviting the sysadmin to revisit
> the config if they later change access (can the installer control in what
> order
> configs are?). Just in case someone chooses the profile temporarily and then
> changes LocalSettings.php.

LocalSettingsGenerator.php controls the order of the configs. The group permissions are right before the "End of automatically generated settings." This patch will put $wgNoFollowLinks and its explanatory comment right after the group rights, so that if/when the system administrator goes to change those to open up the wiki to edits by the general public, hopefully he'll see that too.

Unless the "*" (anon) read right is set to true and the "*" edit right is set to false, $wgNoFollowLinks and its explanatory comment won't appear at all in LocalSettings.php, as it currently doesn't.
Comment 6 Gerrit Notification Bot 2013-12-03 20:17:38 UTC
Change 95755 merged by jenkins-bot:
Set $wgNoFollowLinks to false iff "Authorized editors only" selected

https://gerrit.wikimedia.org/r/95755

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links