Last modified: 2014-09-03 00:28:54 UTC
When running unit tests locally. 1) PrefixUniquenessTest::testPrefixes Module prefix 'uc' is shared between ApiQueryAllCampaigns and ApiQueryContributions
To be fair, I'm not sure if this is actually easy, as one might have to consider backwards compatability (I'm not sure how much we care about that)
Implementing backwards compatibility is near-impossible due to how the API is designed, so this is just a one line change. Whoever does implement this should make sure to send an email to the mediawiki-api list (and ask someone to forward it on to mediawiki-api-announce) since this is a breaking change.
Sigh, yuvi. Marking as a candidate for GCI.
Which prefix should be used instead of 'uc'?
A Google Code-in student (Bene*) has claimed this task: http://www.google-melange.com/gci/task/view/google/gci2013/5213883199389696
(In reply to comment #4) > Which prefix should be used instead of 'uc'? Anything not already taken is probably fine. Normally we use initials, but ac is already taken as well. Perhaps uwc for upload wizard campaign?
uwc sounds fine. We will be killing backwards compatibility, though - but that's fine by me. We might want to get one of the folks with access to the API logs to take a look but (this is optional!)
Change 98174 had a related patch set uploaded by Bene: (bug 57128) Changing ApiQueryAllCampaigns api module prefix https://gerrit.wikimedia.org/r/98174
Change 98174 had a related patch set uploaded by Bene: Changing ApiQueryAllCampaigns api module prefix https://gerrit.wikimedia.org/r/98174
If I understand correctly the comments at the Gerrit changeset, the patch is correct but needs to be announced at the api mailing list and needs to be mentioned in the release notes, right? If the patch itself is correct we can close the GCI task and let the student work in another one, even if we can still ask him to announce the change properly. Please confirm whether the patch itself is correct. Thank you!
This is in extension, so no release notes needed. Email to api list should be done. Patch looks correct at first glance, although I personally haven't had an oportunity to test it.
Thank you! Hoo man also says that this is a good patch. Closing the GCI task as completed.
(In reply to comment #7) > uwc sounds fine. We will be killing backwards compatibility, though - but > that's fine by me. We might want to get one of the folks with access to the > API > logs to take a look but (this is optional!) No hits for allcampaigns from today's log.
Change 98174 merged by jenkins-bot: Changing ApiQueryAllCampaigns api module prefix https://gerrit.wikimedia.org/r/98174
