Last modified: 2014-02-12 23:48:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59155, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57155 - Images show as new pages
Images show as new pages
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Andrew Green
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-18 02:22 UTC by Jon
Modified: 2014-02-12 23:48 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-11-18 02:22:12 UTC 
view https://en.m.wikipedia.org/wiki/File:Larry_Long_Guitar_Standing.jpg in stable.
Compare it with beta:
https://en.m.wikipedia.org/wiki/File:Larry_Long_Guitar_Standing.jpg?mobileaction=beta

In beta it doesn't check Commons. This means links from the profile page take you to a blank page. No bueno.
Comment 1 Bingle 2013-11-18 02:23:23 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1421
Comment 2 Juliusz Gonera 2013-11-25 20:51:44 UTC 
Both URLs show the same picture for me. Am I missing something?
Comment 3 Jon 2013-11-25 21:22:12 UTC 
Are you in beta and using instant commons magic?
Comment 4 Andre Klapper 2013-11-25 21:28:29 UTC 
I can confirm comment 0 (Firefox 25).
Comment 5 Arthur Richards 2013-12-06 21:56:50 UTC 
I can only replicate this issue when I am logged in to the project.
Comment 6 Jon 2013-12-06 22:02:40 UTC 
See SkinMobileBeta::handleNewPages
Comment 7 Andrew Green 2013-12-09 18:12:09 UTC 
(In reply to comment #6)
> See SkinMobileBeta::handleNewPages

Confirmed: in that method there's a test that incorrectly sends us to the create page prompt.

https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend/3ea1a92f2f20cef1ba853c3e1cfa9c2539236936/includes%2Fskins%2FSkinMobileBeta.php#L100

I'm just digging around to find the proper way to fix it, shouldn't be too long...
Comment 8 Gerrit Notification Bot 2013-12-11 05:25:05 UTC 
Change 100753 had a related patch set uploaded by AndyRussG:
Don't handle new pages for images or categories

https://gerrit.wikimedia.org/r/100753
Comment 9 Gerrit Notification Bot 2013-12-12 22:39:39 UTC 
Change 100753 merged by jenkins-bot:
Don't handle new pages for files

https://gerrit.wikimedia.org/r/100753
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links