Last modified: 2013-11-30 14:34:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59179, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57179 - Core jquery.placeholder module and github.com/mathiasbynens/jquery-placeholder should be merged
Core jquery.placeholder module and github.com/mathiasbynens/jquery-placeholde...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: 1.23.0 release
Assigned To: Nobody - You can work on this!
https://google-melange.appspot.com/gc...
gci2013
:
Depends on:
Blocks: 47057 55651
  Show dependency treegraph
 
Reported: 2013-11-18 10:36 UTC by Bartosz Dziewoński
Modified: 2013-11-30 14:34 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2013-11-18 10:36:46 UTC
Core jquery.placeholder module and https://github.com/mathiasbynens/jquery-placeholder should be merged. Both are polyfills for 'placeholder' attribute implementation, with each having some features missing from the other one.

Both are MIT-licensed (as of https://gerrit.wikimedia.org/r/#/c/95748/).
Comment 1 Bartosz Dziewoński 2013-11-18 10:46:18 UTC
Features we are missing:
* Support for valHooks and propHooks (bug 55651)
* Clearing placeholders upon form submission (bug 47057)

Features mathiasbynens/jquery-placeholder is missing (bug 47057 comment 5):
* Calling it as $(…).placeholder('Placeholder text') to set placeholder
  (its .placeholder function doesn't accept any arguments).
* Support for inserting values into inputs with placeholders defined –
  dragging text or rightclick-pasting it could result in new value
  being appended to the placeholder or inserted in the middle of it.
Comment 2 Gerrit Notification Bot 2013-11-28 23:09:33 UTC
Change 98137 had a related patch set uploaded by MegaAlex:
Merge jquery.placeholder with github.com/mathiasbynens/jquery-placeholder

https://gerrit.wikimedia.org/r/98137
Comment 3 Gerrit Notification Bot 2013-11-30 14:25:10 UTC
Change 98137 merged by jenkins-bot:
Merge jquery.placeholder with github.com/mathiasbynens/jquery-placeholder

https://gerrit.wikimedia.org/r/98137
Comment 4 Bartosz Dziewoński 2013-11-30 14:34:23 UTC
Done. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links