Last modified: 2014-04-06 12:15:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59196, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57196 - Unclosed strikethrough tag makes strikethrough formatting continue throughout page
Unclosed strikethrough tag makes strikethrough formatting continue throughout...
Status: NEW
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-18 16:02 UTC by Sage Ross
Modified: 2014-04-06 12:15 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sage Ross 2013-11-18 16:02:33 UTC
On this page [1], the "Open questions" section ends with a line that has starts with <s> but later has another <s> instead of </s>. The strikethrough ends with the second tag anyway, when the page is being viewed normally. With VisualEditor, however, the strikethrough formatting continues to the end of the page.

[1] = https://www.mediawiki.org/w/index.php?title=Wikipedia_Education_Program&oldid=821826
Comment 1 Sage Ross 2013-11-18 16:08:12 UTC
Also, when I removed the entire section that included the offending strikethrough tags, the VE still showed strikethrough on the remainder of the page.

When I open it again in VE after the edit [1], it appears as expected.

[1] = https://www.mediawiki.org/w/index.php?title=Wikipedia_Education_Program&diff=821838&oldid=821826
Comment 2 Gabriel Wicke 2013-12-04 01:25:27 UTC
This is a difference between tidy used by MediaWiki in production and the HTML5 spec. Tidy closes unclosed formatting elements eagerly, while the HTML5 spec demands that formatting elements are restored in most cases.

We are considering to prevent formatting elements from bleeding out of transclusions (see bug 50536) for reasons of correctness and performance, but so far we don't have plans to generally move away from HTML5-compliant (and MediaWiki without tidy) behavior for this.

We can detect unclosed tags and provide information for fix-ups in the wikitext though. That is partly tracked in bug 50547. I thought that we had another bug for this, but don't currently find it. Will add a link to bug 50547 when I find it.
Comment 3 Martijn Hoekstra 2014-04-06 12:00:53 UTC
This comment is basically a +1/me too. The same issue exhibits on https://en.wikipedia.org/w/index.php?title=Actor_model&oldid=602988700 but with a <tt> rather than a <s>. After some discussion with thedj on IRC he suggested I'd file here anyway, if only to indicate it might be somewhat prevalent in the wild.

Personally, I think this is a bug in tidy rather than in VE, and the most reasonable behaviour would be for tidy to conform to prevalent browser behaviour/the HTML spec, and to emit a warning about the likely location of the breakage (where tidy now closes the element)
Comment 4 Bartosz Dziewoński 2014-04-06 12:15:27 UTC
(Tracking bug for Tidy being a piece of junk is bug 2542, by the way.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links