Last modified: 2014-11-01 15:56:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59216, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57216 - VisualEditor: Galleries containing refs produce errors, unless the <references /> are displayed within the gallery
VisualEditor: Galleries containing refs produce errors, unless the <referenc...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-18 23:34 UTC by WhatamIdoing
Modified: 2014-11-01 15:56 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2013-11-18 23:34:00 UTC
Intention:
Edit a page containing a gallery.  The gallery contains <ref> citations.

Steps to Reproduce:
1. Open the page in VisualEditor.
2. Notice the big red errors inside each gallery that contains a <ref> citation.


Actual Results:  
Big red errors are present at the bottom of each gallery that contains a <ref> citation.  Depending on whether the ref is part of a group, these are the two errors I saw:

There are <ref group=$1> tags on this page, but the references will not show without a {{reflist|group=$1}} template (see the help page).

There are <ref> tags on this page, but the references will not show without a {{reflist}} template (see the help page).


Expected Results:  
That VisualEditor would not produce an error.  (There were proper {{reflist}} templates at the bottom of the page.)

Reproducible: Always
Comment 1 WhatamIdoing 2013-11-18 23:35:43 UTC
If you change a caption in the gallery so that it contains a {{reflist}}, then VisualEditor displays the citations within the gallery (under the green can't-edit-this hash), and this error is not present.
Comment 2 WhatamIdoing 2014-02-20 19:47:02 UTC
Also, as seen by editing https://en.wikipedia.org/w/index.php?oldid=596381198 you cannot re-use any references that are within a gallery block.
Comment 3 Alex Monk 2014-11-01 03:07:29 UTC
I don't think this is valid any more, is it?
Comment 4 WhatamIdoing 2014-11-01 15:56:29 UTC
This has been fixed, sort of:  Instead of a big red error, it now puts a references block at the end of the gallery (re-starting the numbering, and including only refs from the gallery).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links