Last modified: 2013-11-26 23:58:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59223, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57223 - CentralAuth $wgSecureLogin redirect is uncacheable
CentralAuth $wgSecureLogin redirect is uncacheable
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Chris Steipp
: performance
Depends on:
Blocks: 54195
  Show dependency tree / graph
 
Reported: 2013-11-19 01:25 UTC by Tim Starling
Modified: 2013-11-26 23:58 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tim Starling 2013-11-19 01:25:00 UTC 
The redirect added to CentralAuth in Ia1232ac39e8 is effectively uncacheable, since it depends on wfCanIPUseHTTPS(), which can't be varied on in Varnish. The change should probably be reverted. It's essential that /checkLoggedIn be cached if the backend request rate impact of CentralAuth is to be reduced.
Comment 1 Gerrit Notification Bot 2013-11-19 20:09:04 UTC 
Change 96317 had a related patch set uploaded by CSteipp:
Remove https redirect from CentralAutoLogin

https://gerrit.wikimedia.org/r/96317
Comment 2 Chris Steipp 2013-11-19 20:12:16 UTC 
As noted on the patch, that should have been a redundant check, so the AutoLogin piece should be cacheable with Gerrit change #96317.
Comment 3 Gerrit Notification Bot 2013-11-26 23:58:32 UTC 
Change 96317 merged by jenkins-bot:
Remove https redirect from CentralAutoLogin

https://gerrit.wikimedia.org/r/96317
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links