Last modified: 2013-12-13 20:16:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59251, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57251 - attribute names should be treated case insensitive
attribute names should be treated case insensitive
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
DOM (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-19 15:28 UTC by Derk-Jan Hartman
Modified: 2013-12-13 20:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2013-11-19 15:28:37 UTC 
Per http://www.w3.org/TR/html-markup/documents.html#case-insensitivity
attribute names should be treated case insensitive

And they are not because:
In https://parsoid.wmflabs.org/enwiki/Channel_Tunnel?oldid=581851617 you have ROWSPAN and COLSPAN and these do not seem to get interpreted by parsoid. This is easily witnessed if you set "border=1" on the table using a web inspector.
Comment 1 Gerrit Notification Bot 2013-12-04 01:41:39 UTC 
Change 99018 had a related patch set uploaded by GWicke:
Bug 57251: Lowercase attributes before sanitization

https://gerrit.wikimedia.org/r/99018
Comment 2 Gabriel Wicke 2013-12-04 01:43:09 UTC 
Good catch! We actually forgot to lowercase all attributes before checking them against the attribute whitelist in the sanitizer. That is now fixed.

We still don't preserve the case when serializing without selser. Whether that is an issue in practice remains to be seen.
Comment 3 Gerrit Notification Bot 2013-12-04 02:51:23 UTC 
Change 99018 merged by jenkins-bot:
Bug 57251: Lowercase attributes before sanitization

https://gerrit.wikimedia.org/r/99018
Comment 5 Gerrit Notification Bot 2013-12-13 19:54:04 UTC 
Change 101278 had a related patch set uploaded by GWicke:
Merge "Bug 57251: Lowercase attributes before sanitization"

https://gerrit.wikimedia.org/r/101278
Comment 6 Gerrit Notification Bot 2013-12-13 19:55:31 UTC 
Change 101330 had a related patch set uploaded by GWicke:
Bug 57251: Lowercase attributes before sanitization

https://gerrit.wikimedia.org/r/101330
Comment 7 Gerrit Notification Bot 2013-12-13 19:57:04 UTC 
Change 101278 merged by GWicke:
Merge "Bug 57251: Lowercase attributes before sanitization"

https://gerrit.wikimedia.org/r/101278
Comment 8 Gerrit Notification Bot 2013-12-13 19:57:06 UTC 
Change 101330 merged by GWicke:
Bug 57251: Lowercase attributes before sanitization

https://gerrit.wikimedia.org/r/101330
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links