Last modified: 2014-10-28 15:30:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59252, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57252 - Cite: Reference extension outputs unescaped fragments in parsoid
Cite: Reference extension outputs unescaped fragments in parsoid
Status: ASSIGNED
Product: Parsoid
Classification: Unclassified
DOM (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-19 15:43 UTC by Derk-Jan Hartman
Modified: 2014-10-28 15:30 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2013-11-19 15:43:09 UTC
https://parsoid.wmflabs.org/enwiki/Channel_Tunnel?oldid=581851617

Parsoid is outputting IDs with spaces in the fragment.

<li about="#cite_note-EU reg impact 220-222-86" id="cite_note-EU reg impact 220-222-86" data-parsoid="{}"><span rel="mw:referencedBy"><a href="#cite_ref-EU reg impact 220-222-86-0">↑</a></span> European Commission pp. 220–222</li>


PHP output:

<li id="cite_note-EU_reg_impact_220-222-86"><span class="mw-cite-backlink"><b><a href="#cite_ref-EU_reg_impact_220-222_86-0"><span class="cite-accessibility-label">Jump up </span>^</a></b></span> <span class="reference-text">European Commission pp. 220–222</span></li>
Comment 1 Derk-Jan Hartman 2013-11-19 17:29:23 UTC

*** This bug has been marked as a duplicate of bug 55400 ***
Comment 2 Gabriel Wicke 2013-11-19 18:59:35 UTC
This looks like a separate issue (no id munging similar to the XHTML4-style PHP behavior), so reopening.
Comment 3 ssastry 2013-11-21 20:27:44 UTC
Restrictions on id attributes in HTML5: http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#the-id-attribute

Those same restrictions also apply to <a> anchors since page-anchors in #-style use element ids.

RDF about attribtues dont accept spaces either. So, using the id-element restrictions on the ref-target and using that in <span id>, <li about/id>, <a href> should work.
Comment 4 Gerrit Notification Bot 2013-11-21 21:49:26 UTC
Change 96892 had a related patch set uploaded by Subramanya Sastry:
(Bug 57252) Generate HTML5-compliant cite id/about attr values

https://gerrit.wikimedia.org/r/96892
Comment 5 Gabriel Wicke 2013-11-21 21:59:50 UTC
I'd love to leave the weird XHTML4 encoding I added a while ago behind. We should investigate whether people are linking to current citations from other pages. If they do, then we might want to consider not breaking those links for now.
Comment 6 John Mark Vandenberg 2013-11-22 03:56:28 UTC
(In reply to comment #5)
> I'd love to leave the weird XHTML4 encoding I added a while ago behind. We
> should investigate whether people are linking to current citations from other
> pages. If they do, then we might want to consider not breaking those links
> for
> now.

They are used in links from the talk page. Those could be addressed with oldid links, if the old versions kept the same ids; tho that may be more work.
Comment 7 Gerrit Notification Bot 2014-01-03 23:22:16 UTC
Change 105406 had a related patch set uploaded by Subramanya Sastry:
(Bug 57252) Generate HTML5-compliant cite id/about attr values

https://gerrit.wikimedia.org/r/105406
Comment 8 Gerrit Notification Bot 2014-01-03 23:23:38 UTC
Change 96892 abandoned by Subramanya Sastry:
(Bug 57252) Generate HTML5-compliant cite id/about attr values

Reason:
Migrated to the new repo (https://gerrit.wikimedia.org/r/#/c/105406/)

https://gerrit.wikimedia.org/r/96892
Comment 9 Gerrit Notification Bot 2014-10-28 15:30:51 UTC
Change 105406 merged by jenkins-bot:
(Bug 57252) Generate HTML5-compliant cite id/about attr values

https://gerrit.wikimedia.org/r/105406

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links