Last modified: 2013-12-02 16:06:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59274, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57274 - export REUSE_BROWSER for 4 VisualEditor tests in Jenkins builds
export REUSE_BROWSER for 4 VisualEditor tests in Jenkins builds
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-19 22:22 UTC by Chris McMahon
Modified: 2013-12-02 16:06 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2013-11-19 22:22:20 UTC
As of today we have four tests that use the @make_selectable_line and @edit_user_page hooks, and that pass with or without the REUSE_BROWSER env variable.  

I suggest we set that env variable REUSE_BROWSER=true for 

bullets.feature
indent_outdent.feature
headings.feature
general_markup.feature

This will save a significant amount of time for each of the four VE builds, since the four tests will log in only four times per build instead of a total of twenty-one times without REUSE_BROWSER=true. 

Note that setting REUSE_BROWSER=true does not affect our ability to analyze test failures.  For example, see the failure messages below for a run of the bullets test: 

----

timed out after 10 seconds (Watir::Wait::TimeoutError)
./features/step_definitions/bullets_steps.rb:26:in `block (2 levels) in <top (required)>'
./features/step_definitions/bullets_steps.rb:25:in `/^a \# is added in front of input string in the diff view$/'
features/bullets.feature:8:in `Then a <character> is added in front of input string in the diff view'

timed out after 10 seconds (Watir::Wait::TimeoutError)
./features/step_definitions/bullets_steps.rb:39:in `block (2 levels) in <top (required)>'
./features/step_definitions/bullets_steps.rb:38:in `/^a \* is added in front of input string in the diff view$/'
features/bullets.feature:8:in `Then a <character> is added in front of input string in the diff view'

timed out after 10 seconds (Watir::Wait::TimeoutError)
./features/step_definitions/bullets_steps.rb:52:in `block (2 levels) in <top (required)>'
./features/step_definitions/bullets_steps.rb:51:in `/^a \#\# is added in front of input string in the diff view$/'
features/bullets.feature:21:in `Then a <character> is added in front of input string in the diff view'

timed out after 10 seconds (Watir::Wait::TimeoutError)
./features/step_definitions/bullets_steps.rb:61:in `block (2 levels) in <top (required)>'
./features/step_definitions/bullets_steps.rb:60:in `/^a \*\* is added in front of input string in the diff view$/'
features/bullets.feature:21:in `Then a <character> is added in front of input string in the diff view'
Comment 1 Željko Filipin 2013-11-20 12:21:38 UTC
I am **strongly against** reusing browsers between scenarios, for various reasons. If speed is our problem, we should run the tests in parallel.
Comment 2 Željko Filipin 2013-12-02 16:06:00 UTC
As far as I remember we have agreed this will not be implemented. Please reopen if I misunderstood.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links