Last modified: 2014-01-03 18:04:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59305, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57305 - "Notes" section says "private" even when public
"Notes" section says "private" even when public
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Tony Thomas
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-20 15:30 UTC by PiRSquared17
Modified: 2014-01-03 18:04 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description PiRSquared17 2013-11-20 15:30:36 UTC
Example: https://meta.wikimedia.org/wiki/Special:AbuseFilter/71
The "description" says "publicly viewable", but the "Notes" are "private". If you log out, you can confirm that the notes are actually public, so I believe the message should be changed.
Comment 1 PiRSquared17 2013-12-02 19:57:39 UTC
(In reply to comment #0)
> [...] so I believe
> the message should be changed.

Or removed.
Comment 2 Gerrit Notification Bot 2013-12-31 19:50:35 UTC
Change 104761 had a related patch set uploaded by 01tonythomas:
Reworded visibility status of "Notes" section to 'publicly viewable'

https://gerrit.wikimedia.org/r/104761
Comment 3 se4598 2014-01-01 11:22:04 UTC
the notes are private, but only if the filter is set to private ("Hide details of this filter from public view"), but the description (also known as filter-title) is then still visible for everyone. That's the explanation of "private".
Comment 4 Jesús Martínez Novo (Ciencia Al Poder) 2014-01-01 17:54:17 UTC
(In reply to comment #3)
> the notes are private, but only if the filter is set to private ("Hide
> details
> of this filter from public view"), but the description (also known as
> filter-title) is then still visible for everyone. That's the explanation of
> "private".

The "Conditions" section doesn't include any mention about being public or private, and has the same visibility than the "Notes" section, so I suggest to simply remove the "(private)" text from the message.
Comment 5 Tony Thomas 2014-01-03 05:13:51 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > the notes are private, but only if the filter is set to private ("Hide
> > details
> > of this filter from public view"), but the description (also known as
> > filter-title) is then still visible for everyone. That's the explanation of
> > "private".
> 
> The "Conditions" section doesn't include any mention about being public or
> private, and has the same visibility than the "Notes" section, so I suggest
> to
> simply remove the "(private)" text from the message.
Removed.
Comment 6 Marius Hoch 2014-01-03 18:04:00 UTC
Merged the patch
Comment 7 Gerrit Notification Bot 2014-01-03 18:04:52 UTC
Change 104761 merged by jenkins-bot:
Removed visibility status of "Notes" section

https://gerrit.wikimedia.org/r/104761

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links