Last modified: 2013-11-22 17:23:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59316, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57316 - CirrusSearch should move all of its search updates to the job queue
CirrusSearch should move all of its search updates to the job queue
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nik Everett
cirrus_reenable
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-20 18:56 UTC by Nik Everett
Modified: 2013-11-22 17:23 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nik Everett 2013-11-20 18:56:27 UTC
CirrusSearch should move all of its search updates to the job queue.
Comment 1 Chad H. 2013-11-20 19:22:56 UTC
If we're only tying into LinksUpdate behavior, we'll need to make sure we handle moves/deletions ok still.

I kind of hate SearchUpdate anyway, so I'm fine with ditching it.
Comment 2 Nik Everett 2013-11-20 19:25:11 UTC
yup.
Comment 3 Dan Garry 2013-11-20 20:55:57 UTC
Chad informs me that this shouldn't affect users very much; this will move Cirrus from instant updating to it taking a few seconds (or, worst case, minutes), which is still a gigantic improvement over Lucene's once-per-day update.
Comment 4 Nik Everett 2013-11-20 21:02:06 UTC
For those following along at home the advantage to this is that if something horrible happens to Elasticsearch then users don't don't end up waiting around for it to recover.  We're already getting most of the way there with Bug 57215 but this makes double sure of it.  It also allows some cleanup from a code standpoint which is nice too.
Comment 5 Gerrit Notification Bot 2013-11-21 22:33:04 UTC
Change 96898 had a related patch set uploaded by Manybubbles:
Perform Elasticsearch updates with queued jobs

https://gerrit.wikimedia.org/r/96898
Comment 6 Gerrit Notification Bot 2013-11-22 17:11:18 UTC
Change 96898 merged by jenkins-bot:
Perform Elasticsearch updates with queued jobs

https://gerrit.wikimedia.org/r/96898

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links