Last modified: 2013-11-23 12:13:42 UTC
Request for disabling the "+2 triggers auto-merge" on gerrit/jenkins for all extensions maintained by user Wikinaut I never liked the "+2 ==> auto-merging" for my extensions. Can someone please switch this off for my extensions, thanks in advance, or tell me how I can disable that ?
The workflow being used is that people use Code-Review +2 to notify the change is ready to be merged. The automatic tests are run and if they pass, the change lands in the branch automatically. So just vote +1 ?
(In reply to comment #1) > The workflow being used is that people use Code-Review +2 to notify the > change > is ready to be merged. The automatic tests are run and if they pass, the > change lands in the branch automatically. > > So just vote +1 ? Antoine, I agree with you. But it may also happen, that one accidentially clicks +2 with the consequence, that the commit is immediately merged. Perhaps it's worth to add one further confirmation window "do you really want to merge" for that case.
I'm highly against "Did you really want to click what you just clicked" dialogs. plus Git offers you the chance to revert the last change.
(In reply to comment #3) > I'm highly against "Did you really want to click what you just clicked" > dialogs. plus Git offers you the chance to revert the last change. Andre, you can say what you want, freedom of speech, but I filed this issue as a personal wish, that the extensions maintained by myself are not auto-merging-on+2, respectfully stated, I wish to maintain this request (reopened). I did not say, that it is a bug.
We can discuss this in the chat. I am *in* now.
