Last modified: 2014-03-28 10:36:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59337, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57337 - #display_point should not set a zoom if coordinates are null
#display_point should not set a zoom if coordinates are null
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Maps (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-21 01:35 UTC by Yaron Koren
Modified: 2014-03-28 10:36 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yaron Koren 2013-11-21 01:35:46 UTC
Hi,

You can see the issue here:

http://semantic-mediawiki.org/wiki/Yaron%27s_location

This page calls a template, which calls #display_point - the "coordinates" parameter is set to null, while the "zoom" parameter is set to 7. So, what shows up on the map is a highly-zoomed view of a location somewhere off the coast of Africa. Instead, if the coordinates (or address, etc.) are null, I would think #display_point should ignore the "zoom" parameter, and always set to it the lowest zoom level, i.e. show the whole world.
Comment 1 Jeroen De Dauw 2013-11-21 15:48:44 UTC
This is a feature, not a bug! :)

If the change is made that you suggest, then one is no longer able to show a map of some region without placing any markers on it.
Comment 2 Jeroen De Dauw 2013-11-21 15:51:55 UTC
While I think changing the current default behaviour is not a good idea, adding a new feature for this could work. Semantic Maps by default simply does not show the map if there are no results, and there this behaviour can be toggled using the "forceshow" parameter. Feel free to file an enhancement request.
Comment 3 Yaron Koren 2013-11-21 16:04:15 UTC
This doesn't make sense to me - there's no way that a null value for coordinates, address, etc. is meant to be a directive to show the location at "0, 0". Surely a null value here merits some special handling?
Comment 4 Yaron Koren 2013-11-21 23:57:43 UTC
Hi - thanks for re-opening this bug; although labeling it as an enhancement doesn't make sense to me. If no point/center is set, showing the entire world seems reasonable, and so does not showing a map at all - but I just can't imagine that showing some islands off the coast of Africa would ever be considered ideal behavior.
Comment 5 Yaron Koren 2013-12-02 23:03:48 UTC
I'm changing this back to severity "normal", from "enhancement" - sorry, I don't think there's any way that the current behavior can be considered correct.
Comment 6 Jeroen De Dauw 2014-03-28 10:36:26 UTC
https://github.com/JeroenDeDauw/Maps/issues/20

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links