Last modified: 2014-02-21 21:51:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59363, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57363 - Enhance hooks.rb in mediawiki-selenium gem to warn when BROWSER_LABEL is undefined
Enhance hooks.rb in mediawiki-selenium gem to warn when BROWSER_LABEL is unde...
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-21 18:37 UTC by Jeff Hall
Modified: 2014-02-21 21:51 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jeff Hall 2013-11-21 18:37:21 UTC
This is a follow-up to this recent change to the VisualEditor browser tests:

https://gerrit.wikimedia.org/r/#/c/96793/

Since a user may neglect to explicitly export a value for the BROWSER_LABEL environment variable, it might be a good idea to enhance hooks.rb for the mediawiki-selenium RubyGem to add a warning where that value is undefined.  

The danger is that where the BROWSER_LABEL value is undefined, individual tests will not target the intended wiki pages, since those pages are expected to have the BROWSER_LABEL string included in the page URL.

The hooks.rb file already issues similar warnings for the MEDIAWIKI_USER and MEDIAWIKI_PASSWORD variables in the "Before('@login')" method:

https://github.com/wikimedia/mediawiki-selenium/blob/master/lib/mediawiki/selenium/hooks.rb
Comment 1 Jeff Hall 2014-02-21 21:51:06 UTC
This task is invalid now that warnings for undefined BROWSER, PLATFORM and VERSION environment variable values have been added to env.rb in the most recent versions of the mediawiki_selenium Rubygem, so closing this ticket as INVALID.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links