Last modified: 2014-02-05 17:19:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59401, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 57401 - Padding values of div#content were (accidentially?) changed (in LESS rewrite?)


Summary:	Padding values of div#content were (accidentially?) changed (in LESS rewrite?)

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Interface (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	1.23.0 release
Assigned To:	Liangent

URL:
Whiteboard:
Keywords:	code-update-regression, easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-22 07:06 UTC by Liangent
Modified:	2014-02-05 17:19 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2013-11-22 07:06:14 UTC

For small screens, it now has:

  padding: 1.5em 1.5em 1.5em 1.75em;

For big screens (982px+), it now has:

  padding: 1.25em 1.5em 1.5em;

Some time ago, these values was:

  padding: 1em; (small)
  padding: 1.25em 1.5em 1.5em 1.5em; (big)

Anyway it's not reasonable to use bigger paddings now for smaller screens.

Comment 1 Bartosz Dziewoński 2013-12-23 19:51:29 UTC

Fixed in I2551ab16. I couldn't find this bug when committing that, heh.

Comment 2 Liangent 2013-12-24 01:56:03 UTC

(In reply to comment #1)
> Fixed in I2551ab16. I couldn't find this bug when committing that, heh.

So finally both paddings got enlarged, not changed back to original values?

Comment 3 Bartosz Dziewoński 2013-12-24 10:09:56 UTC

Oh, hmm. So it would seem, yeah.

Comment 4 Liangent 2013-12-24 14:20:19 UTC

(In reply to comment #3)
> Oh, hmm. So it would seem, yeah.

And it won't be changed back?

Comment 5 Bartosz Dziewoński 2013-12-24 14:38:48 UTC

Unless you submit a patch ;) The change seems unintentional to me.

Comment 6 Gerrit Notification Bot 2014-02-05 15:23:51 UTC

Change 111454 had a related patch set uploaded by Liangent:
(bug 57401) Fix padding values of div#content

https://gerrit.wikimedia.org/r/111454

Comment 7 Bartosz Dziewoński 2014-02-05 17:15:02 UTC

Thanks.

Comment 8 Gerrit Notification Bot 2014-02-05 17:19:29 UTC

Change 111454 merged by jenkins-bot:
Vector: Fix padding values of div#content

https://gerrit.wikimedia.org/r/111454

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links