Last modified: 2013-12-13 20:37:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59421, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57421 - VisualEditor: MWExtensionInspector does not take directionality from context when creating
VisualEditor: MWExtensionInspector does not take directionality from context ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-12-19
Assigned To: Moriel Schottlender
: i18n
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-22 13:01 UTC by Roan Kattouw
Modified: 2013-12-13 20:37 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-11-22 13:01:38 UTC 
https://gerrit.wikimedia.org/r/#/c/96984/ adds a workaround for the fact that getting the directionality from the FocusedNode doesn't work if there is no node focused (i.e. in creation mode), but it doesn't add any alternative logic for getting the directionality. We should look at the context in the CE tree somehow and figure out what directionality to use. Right now it just defaults to the UI directionality.
Comment 1 Gerrit Notification Bot 2013-12-12 22:20:08 UTC 
Change 101125 had a related patch set uploaded by Mooeypoo:
Add a getDirectionFromRange Method to ve.ce.Document

https://gerrit.wikimedia.org/r/101125
Comment 2 Gerrit Notification Bot 2013-12-13 20:24:25 UTC 
Change 101125 merged by jenkins-bot:
Add a getDirectionFromRange Method to ve.ce.Document

https://gerrit.wikimedia.org/r/101125
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links