Last modified: 2014-05-27 10:20:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59430, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57430 - Git is slow & big
Git is slow & big
Status: RESOLVED WORKSFORME
Product: MediaWiki-Vagrant
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Ori Livneh
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-22 17:38 UTC by Tisza Gergő
Modified: 2014-05-27 10:20 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2013-11-22 17:38:53 UTC
Git operations on /vagrant/mediawiki are a bit slow, and the cloning (when running 'vagrant up' takes several minutes. Also, the size of the repo is 0.5GB.

This is probably because the full history is cloned; I doubt many developers need that. By default, mediawiki-vagrant should do a shallow clone (possibly with a configuration parameter to change it).
Comment 1 Ori Livneh 2013-11-25 09:58:30 UTC
git-clone was in fact shallow prior to Gerrit change I9742facc6, and the setting was parametrized prior to I4c475126a.

One issue with shallow clones is that git-review will pull the entire history anyway, except it will do so silently, and at point in time where the user is not expecting it (that is, upon patch submission).

Another thing to consider is the reason Git is so slow. Network costs are only a part of the story. Until the user runs 'update-guest-additions', the VM will run with an old version of VirtualBox Guest Additions, and thus an older implementation of VirtualBox Shared Folders, the filesystem driver used to share a path between guest and host; its performance is abysmal, especially when creating lots of small files.

It'd probably be good to re-parametrize the clone depth; I'm not sure why I removed the parameter, to be honest.
Comment 2 Tisza Gergő 2013-11-25 12:44:27 UTC
I guess this should be a git-review bug then (or maybe I just don't understand how it works; but I would expect that as long as the closest parent commit which is already merged can be found locally, git-review has no need of the rest).

Re: VirtualBox Shared Folders, couldn't mediawiki-vagrant just use NFS on linux hosts? If the filesystem is indeed a problem, that would speed up HTTP response times as well as git speed.
Comment 3 Ori Livneh 2014-05-27 10:20:37 UTC
(In reply to Tisza Gergő from comment #2)
> Re: VirtualBox Shared Folders, couldn't mediawiki-vagrant just use NFS on
> linux hosts? If the filesystem is indeed a problem, that would speed up HTTP
> response times as well as git speed.

Done, as of Ia9214dcd5

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links