Last modified: 2014-04-02 13:47:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59436, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57436 - Typography refresh dramatically increase Wikibase items label font
Typography refresh dramatically increase Wikibase items label font
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: TMg
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-22 18:35 UTC by Tpt
Modified: 2014-04-02 13:47 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of the issue (154.65 KB, image/png)
2013-11-22 18:35 UTC, Tpt
Details

Description Tpt 2013-11-22 18:35:58 UTC
Created attachment 13885 [details]
Screenshot of the issue

There looks like to be an issue between Wikibase and Typographic refresh beta option: Wikibase item label, in view and edit mode, looks very big when the option is activated.
Comment 1 Jon 2013-11-23 01:31:10 UTC
I think this would be better recorded - https://www.mediawiki.org/wiki/Talk:Typography_Update

This feature is actually provided by VectorBeta so filed in the wrong place. It is very likely to disappear into Bugzilla by being placed here...
Comment 2 Bartosz Dziewoński 2013-11-23 12:22:37 UTC
Jon, I think you have the 'editbugs' right? Do move the bug in a better place.

It's difficult to tell what is the right place for me at least, though, since the feature is partially in core and partially in two different extensions. There is also no component for VectorBeta, I think you should get that fixed.
Comment 3 Andre Klapper 2013-11-23 15:13:03 UTC
(In reply to comment #2)
> There is also no component for VectorBeta, I think you should get that fixed.

https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component
Comment 4 Michael M. 2013-11-25 09:34:14 UTC
I'd say that WikiData is the component this bug belongs to. Here are the relevant styles:

The headline is a <h1 class="wb-value-row wb-firstHeading"><span class="wb-value">Foo</span></h1> (plus lots of other classes and ids, but these are the relevant ones).

Normal Vector styles are

h1 { font-size: 188%; }

Beta Vector styles are

#content h1 { font-size: 1.833em; }

(which is almost the same, but more specific)

WikiData styles are

.wb-value-row { font-size: 100%; }
.wb-firstHeading .wb-value { font-size: 188%; }

So in normal Vector the .wb-value-row style overrides the style for h1, and the headline ends up at font-size: 188%, while in Beta the font-size: 100% do not override the 1.833em;, and the final size is 1.833em * 188% = 345%.
Comment 5 Michael M. 2013-11-26 09:05:46 UTC
On the other hand: Just removing the #content from the #content h1 selector may be easier (and there are no <h1> outside #content anyway), which would mean that MediaWiki Core > Skin and page rendering would be the best component for this bug.
Comment 6 Andre Klapper 2013-11-29 12:52:53 UTC
Tpt: Browser information welcome. Also, how to reproduce the problem (steps)?

Tentatively moving to Wikidata as per comment 4.
Wikidata folks: Feel free to move to "MediaWiki > Skin and page rendering" as per comment 5.
Comment 7 Gerrit Notification Bot 2014-02-27 12:44:37 UTC
Change 115893 had a related patch set uploaded by Thiemo Mättig (WMDE):
Typography refresh (VectorBeta extension) makes heading font to big

https://gerrit.wikimedia.org/r/115893
Comment 8 Gerrit Notification Bot 2014-02-28 09:12:30 UTC
Change 115893 merged by jenkins-bot:
Typography refresh (VectorBeta extension) makes heading font to big

https://gerrit.wikimedia.org/r/115893
Comment 9 TMg 2014-02-28 13:23:01 UTC
I fixed this while working on a related design issue with the table of contents (TOC).

Please note that this is a temporary workaround and it's not perfect. The Typography refresh is still in Beta and will change. Please re-open this report if the issue re-appears or the Beta feature causes other issues.
Comment 10 Thiemo Mättig 2014-04-02 13:47:09 UTC
Just to let you know, there is a very closely related change at https://gerrit.wikimedia.org/r/123203 that fixes a wrong font family used.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links