Last modified: 2014-02-20 19:23:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59449, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57449 - Add hooks to MultimediaViewer extension
Add hooks to MultimediaViewer extension
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Dereckson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-22 22:12 UTC by Mark Holmquist
Modified: 2014-02-20 19:23 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Holmquist 2013-11-22 22:12:19 UTC
From an email, from Daniel Schwen (CC'd):

> Ideally I'd like to have a
> * pre- and post- opening of the viewer hook
> * a hook that is called when the displayed image in the viewer changes,
> * and a hook [to] feed a list of 'next' and 'prev' images to the viewer.

We've been thinking about a hooking infrastructure, and this seems like a good list to start with. Thanks Daniel!
Comment 1 Dereckson 2013-11-23 14:55:03 UTC
Note: the lightbox JS code used by the extension already implements the following hooks:
- closeInterface (when the viewer is closed)
- imageLoaded (when image is done loading)

This is documented at /MultimediaViewer/resources/multilightbox/hooks.txt

So we can reuse these twos for our own hooks.
Comment 2 MZMcBride 2013-12-25 00:12:27 UTC
Please write coherent bug summaries.
Comment 3 Gilles Dubuc 2014-02-20 10:46:07 UTC
The course has changed on this, we're now using custom jQuery events. They serve the same purpose. But we've decided not to preemptively add hooks that aren't used yet, this was attempted with lightboxHooks and is hard to do well without a real need. I think it's too early in this extension's lifespan to guess ways people will customize it/hook into it. So for now we'll only create events that are being used in mmv itself to communicate events across isolated components.
Comment 4 Mark Holmquist 2014-02-20 19:23:31 UTC
FYI we'll want to use https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.hook instead, in the future.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links