Last modified: 2014-07-10 21:33:47 UTC
When a user clicks on Switch to source editing option from the settings drop down it tells user that switching to source editing will keep the changes made in the document.But if a user attempts to switch from the tab it does not retain those changes.This seemed confusing to me because when user uses the "switch to source editing" , the "Edit Source" tab is selected ,indicating the same destination for both action. If a user can switch to source editing in multiple ways, i think it is better both ways have similar mechanism of handling the changes to have uniform experience. Specially when switching from tab is one click away compared to the "[]switch to source editing" option.
Created attachment 13890 [details] Inside Edit Source tab
[Removing "[Suggestion]" from summary; setting severity field to "enhancement" instead]
This is possible, but would be ugly, because we'd need to replace the existing two-choice option (switch or don't switch) with a custom three-choice one (switch and keep changes, switch without changes, don't switch)… Maybe.
I personally think that this bug report is a duplicate of bug 42141.
Change 142064 had a related patch set uploaded by Alex Monk: Offer to retain changes when switching to the wikitext editor https://gerrit.wikimedia.org/r/142064
Change 142064 merged by jenkins-bot: Offer to retain changes when switching to the wikitext editor https://gerrit.wikimedia.org/r/142064
Change 143203 had a related patch set uploaded by Alex Monk: Don't offer to retain changes when switching to wikitext editor by tab if no changes have been made. https://gerrit.wikimedia.org/r/143203
Change 143203 merged by jenkins-bot: Don't offer to retain changes when switching to wikitext editor by tab if no changes have been made https://gerrit.wikimedia.org/r/143203
Verified the fix in Betalabs
Verified the fix in test2
Verified the fix in production
