Last modified: 2014-01-28 16:25:06 UTC
2013-11-23 01:02:07 mw1037 enwiki: [889271a1] /favicon.ico Exception from line 1183 of /usr/local/apache/common-local/php-1.23wmf4/includes/WebRequest.php: Invalid IP given in XFF 'unknown, 10.64.0.126'. #0 /usr/local/apache/common-local/php-1.23wmf4/includes/ProxyTools.php(59): WebRequest->getIP() #1 /usr/local/apache/common-local/wmf-config/throttle.php(65): wfGetIP() #2 [internal function]: efRaiseAccountCreationThrottle() #3 /usr/local/apache/common-local/php-1.23wmf4/includes/Setup.php(592): call_user_func('efRaiseAccountC...') #4 /usr/local/apache/common-local/php-1.23wmf4/includes/WebStart.php(153): require_once('/usr/local/apac...') #5 /usr/local/apache/common-local/w/favicon.php(5): require('/usr/local/apac...') #6 {main}
(1) we trust a header too much (2) a bug in the IP canon code, maybe
(In reply to comment #0) Are you sure this is a MediaWiki bug? Given the involvement of favicon.php and throttle.php, this seems like a Wikimedia bug. Though maybe you think the issue is somewhere in MediaWiki core's includes/?
(In reply to comment #2) > (In reply to comment #0) > > Are you sure this is a MediaWiki bug? Given the involvement of favicon.php > and > throttle.php, this seems like a Wikimedia bug. Though maybe you think the > issue > is somewhere in MediaWiki core's includes/? The quoted string of 'unknown, 10.64.0.126' looks like the results of bad parsing. But it could easily be a bad header like Marcin said. According to squid.php, 10.64.0.126 or cp1004 is an API caching server.. Slightly confused why that is serving favicon requests, but whatever.
Change 109721 had a related patch set uploaded by Umherirrender: Ignore 'unknown' in XFF https://gerrit.wikimedia.org/r/109721
Change 109721 merged by jenkins-bot: Ignore 'unknown' in XFF https://gerrit.wikimedia.org/r/109721
successfully merged
