Last modified: 2014-08-02 20:31:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59474, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57474 - Very easy to spoof revert notification
Very easy to spoof revert notification
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-23 06:18 UTC by Kunal Mehta (Legoktm)
Modified: 2014-08-02 20:31 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2013-11-23 06:18:41 UTC
Open a page's edit window
Add a input value of 'wpUndidRevision' with some valid revid. Save.
Whoever made that edit will receive an extremely confusing Echo notification.

This can easily be exploited by adding the same parameter to an edit made via the API. A warning will be displayed, but the notification is still sent.

Ideas on how to fix:

Temporary: Check that $rev->getTitle() == $article->getTitle()

Maybe also look into using sha1's to only show reverts for exact reverts.

Long term: Find some other way than using a request value like wpUndidRevision to trigger a notification.
Comment 1 Gerrit Notification Bot 2013-11-23 06:21:35 UTC
Change 97191 had a related patch set uploaded by Legoktm:
Check supposed revision being reverted is on the same page

https://gerrit.wikimedia.org/r/97191
Comment 2 Kunal Mehta (Legoktm) 2013-11-23 06:22:17 UTC
(In reply to comment #0)

> Temporary: Check that $rev->getTitle() == $article->getTitle()

Patch only addresses this for now.
Comment 3 Gerrit Notification Bot 2013-12-17 20:27:44 UTC
Change 97191 merged by jenkins-bot:
Check supposed revision being reverted is on the same page

https://gerrit.wikimedia.org/r/97191

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links