Last modified: 2013-11-26 22:52:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59555, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57555 - VisualEditor: Annotate body tag or #content tag when in edit mode with class
VisualEditor: Annotate body tag or #content tag when in edit mode with class
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-12-05
Assigned To: Rob Moen
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-25 20:03 UTC by Jon
Modified: 2013-11-26 22:52 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-11-25 20:03:43 UTC 
Other modules (and gadgets) should be able to hide their interfaces when VisualEditor is opened - for example the Nearby pages BetaFeature (https://www.mediawiki.org/wiki/Beta_Features/Nearby_Pages) creates a blue button in the top right.

Ideally this feature should be able to know when it is in edit mode and hide itself.

Maybe abusing the action-edit / action-view classes would be useful here?
Comment 1 Gerrit Notification Bot 2013-11-26 10:01:03 UTC 
Change 97702 had a related patch set uploaded by Robmoen:
Toggle veaction-edit class on the body of the view page

https://gerrit.wikimedia.org/r/97702
Comment 2 Gerrit Notification Bot 2013-11-26 22:52:16 UTC 
Change 97702 merged by jenkins-bot:
mw.ViewPageTarget: Use ve-activated class on the html element

https://gerrit.wikimedia.org/r/97702
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links