Last modified: 2014-02-12 23:47:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59556, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57556 - Don't just ajaxSetup in api.js
Don't just ajaxSetup in api.js
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-25 20:20 UTC by Jon
Modified: 2014-02-12 23:47 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-11-25 20:20:46 UTC 
A TODO note in api.js reads "TODO: this might be dangerous and cause conflicts with other code. should we move it to Api#ajax?"

It turns out it conflicts with desktop tools like Twinkle:
https://www.mediawiki.org/wiki/Talk:Beta_Features/Nearby_Pages#Twinkle

Thus, we should do what the TODO note says.
Comment 1 Bingle 2013-11-25 20:21:26 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1447
Comment 2 Gerrit Notification Bot 2013-11-26 20:39:20 UTC 
Change 97832 had a related patch set uploaded by JGonera:
Don't set defaults using $.ajaxSetup()

https://gerrit.wikimedia.org/r/97832
Comment 3 Gerrit Notification Bot 2013-11-26 22:05:16 UTC 
Change 97832 merged by jenkins-bot:
Don't set defaults using $.ajaxSetup()

https://gerrit.wikimedia.org/r/97832
Comment 4 Jon 2013-12-05 23:05:15 UTC 
The fix to this seems to have broken uploads. Reverting this change fixes the problem on Special:Uploads
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links