Last modified: 2014-02-12 23:46:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59559, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57559 - Use mw.user.tokens.get( 'editToken' )
Use mw.user.tokens.get( 'editToken' )
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Unprioritized enhancement
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-25 21:29 UTC by Jon
Modified: 2014-02-12 23:46 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-11-25 21:29:04 UTC 
Since the introduction of mw.user in I708006fd6733cac89128bc76a1cd34c0d091c371

Calling:
mw.user.tokens.get( 'editToken' )

Returns an edit token.
We should probably now be able to reduce or kill our getToken code..
Comment 1 Bingle 2013-11-25 21:29:28 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1451
Comment 2 Gerrit Notification Bot 2013-12-27 01:40:19 UTC 
Change 103887 had a related patch set uploaded by Kaldari:
Migrating some use of api.getToken() to mw.user.tokens.get()

https://gerrit.wikimedia.org/r/103887
Comment 3 Gerrit Notification Bot 2013-12-27 22:55:44 UTC 
Change 103887 abandoned by Kaldari:
Migrating some use of api.getToken() to mw.user.tokens.get()

Reason:
Apparently this is not what was wanted.

https://gerrit.wikimedia.org/r/103887
Comment 4 Gerrit Notification Bot 2013-12-27 23:26:09 UTC 
Change 104160 had a related patch set uploaded by Kaldari:
Add short-curcuit in api.getTokens for tokens availble in user.tokens

https://gerrit.wikimedia.org/r/104160
Comment 5 Jon 2013-12-30 22:27:16 UTC 
Ryan's patch kicks this off but we have to upstream a fair bit to core before we can do this... :(
Comment 6 Gerrit Notification Bot 2013-12-30 22:27:20 UTC 
Change 104160 merged by jenkins-bot:
Add short-curcuit in api.getTokens for tokens availble in user.tokens

https://gerrit.wikimedia.org/r/104160
Comment 7 Jon 2013-12-30 22:58:39 UTC 
I've opened two more specific bugs:
* bug 59148
* bug 59149

We've done all we can here for the time being.
Comment 8 Gerrit Notification Bot 2014-01-03 00:00:08 UTC 
Change 105116 had a related patch set uploaded by Kaldari:
Add short-curcuit in api.getTokens for tokens availble in user.tokens

https://gerrit.wikimedia.org/r/105116
Comment 9 Gerrit Notification Bot 2014-01-10 20:43:00 UTC 
Change 105116 merged by jenkins-bot:
Add short-circuit in api.getTokens for tokens available in user.tokens

https://gerrit.wikimedia.org/r/105116
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links