Last modified: 2014-01-01 20:28:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59563, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57563 - Incorrect CSS rules defining the blocks placement at WM-ES main page
Incorrect CSS rules defining the blocks placement at WM-ES main page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.google-melange.com/gci/tas...
gci2013
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-25 22:59 UTC by Platonides
Modified: 2014-01-01 20:28 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
HomePageWMES.php (6.09 KB, application/x-php)
2013-11-25 23:00 UTC, Platonides
Details
style.css (2.21 KB, text/css)
2013-11-25 23:01 UTC, Platonides
Details
A fix to the bug (260 bytes, patch)
2013-12-31 19:28 UTC, Mateusz Maćkowski
Details
Small enhancement to the second CSS file (286 bytes, patch)
2013-12-31 19:32 UTC, Mateusz Maćkowski
Details

Description Platonides 2013-11-25 22:59:00 UTC
The site http://www.wikimedia.org.es/ is just a MediaWiki install with a custom skin. The main page blocks (Actividades, Participa, Dona, Blog and the slideshow) are achieved with a tag which outputs the needed html.

However, there is a bug in the css, which relies on some element of the custom skin for proper placement. Compare http://www.wikimedia.org.es/wiki/Portada?useskin=wmes (Good: Actividades, Participa & Dona at the left) with http://www.wikimedia.org.es/wiki/Portada?useskin=vector (Wrong: Actividades, Participa & Dona appear on top of the slideshow).

Figure out the wrong rules and provide a patch for fixing the issue, so it works on any skin. Both the html (the php file) and the css can be changed.

Since this extension is not in gerrit, the patch shall be provided on this bug.
Comment 1 Platonides 2013-11-25 23:00:45 UTC
Created attachment 13901 [details]
HomePageWMES.php

Extension file providing the html
Comment 2 Platonides 2013-11-25 23:01:39 UTC
Created attachment 13902 [details]
style.css

CSS file. Can also be found at http://www.wikimedia.org.es/w/extensions/HomePageWMES/style.css
Comment 3 Andre Klapper 2013-11-26 10:58:56 UTC
Hi, these are on-wiki issues which have nothing to do with the MediaWiki software or Wikimedia server configuration. Why was this filed in Bugzilla?
Comment 4 Andre Klapper 2013-11-26 11:23:48 UTC
[Adding "gci2013" whiteboard entry as explained on https://www.mediawiki.org/wiki/Google_Code-in#Mentors.27_corner and to avoid confusion like in comment 3.]
Comment 5 Andre Klapper 2013-12-17 10:46:44 UTC
Platonides: Is there a corresponding task in www.google-melange.com ? What's the URL?
Comment 6 Mateusz Maćkowski 2013-12-31 19:28:46 UTC
Created attachment 14199 [details]
A fix to the bug
Comment 7 Mateusz Maćkowski 2013-12-31 19:32:53 UTC
Created attachment 14200 [details]
Small enhancement to the second CSS file

Created some enhancement to the http://www.wikimedia.es/w/skins/wmes/style.css?303Y CSS file. Since some CSS properties are now handled via the CSS I've previously posted patch to, it's unnecessary to have them at two places.
Comment 8 Mateusz Maćkowski 2013-12-31 19:33:20 UTC
By the way: the URL of the task is http://www.google-melange.com/gci/task/view/google/gci2013/6649325425786880 :)
Comment 9 Platonides 2013-12-31 21:07:05 UTC
The fix is right.
Happy New Year, Mateusz!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links