Wikimedia Bugzilla is closed!

In for example https://gerrit.wikimedia.org/r/#/c/96456/2/includes/db/ORMTable.php, protected DBAccessBase::releaseConnection is overridden as public ORMTable::releaseConnection.

Running CodeSniffer on this, leads to a "useless method overriding" warning. However, the visibility is intentional and valid, so CodeSniffer should not warn.

Example code:

	<?php
	
	class DBAccessBase {
		protected function releaseConnection( DatabaseBase $db ) {
		}
	}
	
	class ORMTable extends DBAccessBase {
		public function releaseConnection( DatabaseBase $db ) {
			parent::releaseConnection( $db ); // just make it public
		}
	}

CodeSniffer output:

FILE: test.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 9 | WARNING | Useless method overriding detected
   |         | (Generic.CodeAnalysis.UselessOverridingMethod.Found)
--------------------------------------------------------------------------------