Last modified: 2014-03-07 17:02:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59593, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 57593 - Parsoid: Server doesn't handle 'error' event for connect


Summary:	Parsoid: Server doesn't handle 'error' event for connect

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	Web API (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Gabriel Wicke

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-26 15:20 UTC by Krinkle
Modified:	2014-03-07 17:02 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2013-11-26 15:20:39 UTC

When starting api/server.js and there is an error, it throws an internal node module exception instead of handling the error.

This can be reproduced when, for example, an EADDRINUSE error is triggered in case of some other random service using port 8000.


ve@dl:~/src/parsoid/js master$ node api/server.js 
 - worker(19466) loading...
 - worker(19472) loading...
 - worker(19468) loading...
 - worker(19469) loading...
 - worker(19470) loading...
 - worker(19466) ready

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: bind EADDRINUSE
    at errnoException (net.js:901:11)
    at net.js:1073:26
    at Object.1:1 (cluster.js:587:5)
    at handleResponse (cluster.js:171:41)
    at respond (cluster.js:192:5)
    at handleMessage (cluster.js:202:5)
    at process.EventEmitter.emit (events.js:117:20)
    at handleMessage (child_process.js:318:10)
    at child_process.js:392:7
    at process.handleConversion.net.Native.got (child_process.js:91:7)
worker 19466 died (8), restarting.
 - worker(19468) ready
 - worker(19472) ready


events.js:72
events.js:72
        throw er; // Unhandled 'error' event
              ^
        throw er; // Unhandled 'error' event
              ^
Error: bind EADDRINUSE
    at errnoException (net.js:901:11)
    at net.js:1073:26
    at Object.5:1 (cluster.js:587:5)
    at handleResponse (cluster.js:171:41)
    at respond (cluster.js:192:5)
    at handleMessage (cluster.js:202:5)
    at process.EventEmitter.emit (events.js:117:20)
    at handleMessage (child_process.js:318:10)
    at child_process.js:392:7
    at process.handleConversion.net.Native.got (child_process.js:91:7)
Error: bind EADDRINUSE
    at errnoException (net.js:901:11)
    at net.js:1073:26
    at Object.2:1 (cluster.js:587:5)
    at handleResponse (cluster.js:171:41)
    at respond (cluster.js:192:5)
    at handleMessage (cluster.js:202:5)
    at process.EventEmitter.emit (events.js:117:20)
    at handleMessage (child_process.js:318:10)
    at child_process.js:392:7
    at process.handleConversion.net.Native.got (child_process.js:91:7)
worker 19472 died (8), restarting.
worker 19468 died (8), restarting.
 - worker(19469) ready

events.js:72
        throw er; // Unhandled 'error' event

Comment 1 Gerrit Notification Bot 2014-02-22 11:22:00 UTC

Change 114928 had a related patch set uploaded by Konarak:
Handle 'error' event for connection

https://gerrit.wikimedia.org/r/114928

Comment 2 Gerrit Notification Bot 2014-03-07 17:01:31 UTC

Change 114928 merged by jenkins-bot:
Handle 'error' event for connection

https://gerrit.wikimedia.org/r/114928

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links