Last modified: 2013-12-05 14:29:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59599, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57599 - make npm learn the 'stop' command
make npm learn the 'stop' command
Status: RESOLVED WONTFIX
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on: 57598
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-26 16:31 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-12-05 14:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2013-11-26 16:31:11 UTC
The npm packages.json in /js/ has a a start command bound to node api/server.js. In conjunction with bug 57598 which ask server.js to record the pid via a new --pidfile option, one could then implement the 'npm stop' command to let folks easily stop the daemon.
Comment 1 Arlo Breault 2013-11-27 21:34:28 UTC
I don't you can pass arguments to npm's run-script.
See: https://github.com/isaacs/npm/issues/3494
Comment 2 Arlo Breault 2013-12-03 20:25:10 UTC
In this case, I would recommend not use npm start. Just use node api/server.js and start-stop-daemon with -m
Comment 3 Antoine "hashar" Musso (WMF) 2013-12-05 14:29:33 UTC
(In reply to comment #2)
> In this case, I would recommend not use npm start. Just use node
> api/server.js and start-stop-daemon with -m

Indeed.  I was expecting 'npm start' and 'npm stop' to be the recommended way of acting with the daemon.  I was wrong :-]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links